Repository navigation
ci: read v1 deploy and publish secrets from aws secrets manager - #62957
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
deploy.ymlassumesarn:aws:iam::604439173067:role/github/opencode-v1in thev1environment and fetchesopencode/v1/{CLOUDFLARE_API_TOKEN,SENTRY_AUTH_TOKEN}.publish.ymlassumesarn:aws:iam::604439173067:role/github/opencode-releasein thereleaseenvironment:opencode/release/{OPENCODE_API_KEY,SENTRY_AUTH_TOKEN,RELEASE_TAG_KEY,DISCORD_WEBHOOK}andshared/{APPLE_SIGNING_CERTIFICATE,APPLE_NOTARY_KEY,AUR_SSH_KEY,HOMEBREW_TAP_DEPLOY_KEY}.AUR_SSH_KEYis aliased back toAUR_KEY, which the scripts read.AZURE_*trusted signing ids are repo variables now.RELEASE_TAG_KEYis fetched before the checkout in thepublishjob, because it is that checkout'sssh-key.versioncarry the same condition as itsenvironment:(inputs.bump || inputs.version), so a push preview never tries to assume the role.TAURI_SIGNING_PRIVATE_KEY(_PASSWORD): neither is set anywhere, andscript/publish.tsalready skipslatest.jsonand logs that.notify-discord.ymlinto the end of thepublishjob. areleaseevent runs with a tag ref and thereleaseenvironment only allows thedevandv1branches, so that workflow could never assume the role. it now readsopencode/release/DISCORD_WEBHOOKand hands the release name, body and url to the same action.lib.shunset fix from ci: read deploy and release secrets from aws secrets manager #62954 has no v1 equivalent.unlock.yml: it readsvars.AWS_DEPLOY_ROLE_ARNand the stripe secrets, none of which exist.publish-vscode.yml:VSCE_PATandOPENVSX_TOKENare not set, and no run under that name ever used this file (the v1 copy'sRequire a v1 commitstep appears in none of its runs), so v1's copy has never run.opencode.yml,triage.yml,duplicate-issues.yml,review.yml,pr-management.yml,docs-update.yml,stats.yml).issues,issue_comment,pull_request_targetandscheduleonly run the workflow file from the default branch, andgh run listshows all of their runs ondev.secrets.references left on v1 aresecrets.GITHUB_TOKEN.unused once this and #62954 are both merged, since dev and v1 then read aws:
AZURE_CLIENT_ID,AZURE_TENANT_ID,AZURE_SUBSCRIPTION_ID,AZURE_TRUSTED_SIGNING_ACCOUNT_NAME,AZURE_TRUSTED_SIGNING_CERTIFICATE_PROFILE,AZURE_TRUSTED_SIGNING_ENDPOINT,DISCORD_WEBHOOK,OPENCODE_API_KEY,PLANETSCALE_SERVICE_TOKEN,PLANETSCALE_SERVICE_TOKEN_NAMEdev:CLOUDFLARE_API_TOKENproduction:CLOUDFLARE_API_TOKENrelease:APPLE_NOTARY_KEY,APPLE_SIGNING_CERTIFICATE,CLOUDFLARE_API_TOKEN,HOMEBREW_TAP_DEPLOY_KEY,RELEASE_TAG_KEYv1:CLOUDFLARE_API_TOKENkeeps:
AUR_KEY:sst,opentunnel,torpedoand thepulumi-*repos still use it.SENTRY_AUTH_TOKEN: devdeploy.ymlstill passes it for thebetastage, which has no branch.— from 𝕺𝖕𝖊𝖓𝕮𝖔𝖉𝖊