Repository navigation
fix(app): calmer background shell pill - #59480
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
The change looks sound. I read the code and ran the type check (tsc -b) and the activity elapsed browser test, both passing. I couldn't check it visually: there is no browser in the sandbox for the Playwright component spec.
Keyboard users still see which row is active, because the menu's [data-highlighted] fill shows for keyboard focus as well as hover. The stop button can't be reached by Tab (tabIndex={-1}), so dropping its ring doesn't matter. Other menus don't give their rows an outline either.
Public API: unchanged.
No concerns.
kitlangton
force-pushed
the
shell-pill
branch
from
October 28, 2026 17:01
bd097cd to
12cd26c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hovering a background shell in the pill no longer draws a blue ring around the row.
The pill above the composer lists running background shells. Pointing at a row moves keyboard focus onto it, and the panel styled focus with the bright focus border, so a plain hover looked like a selected or broken row. Rows now get only the menu's usual quiet hover fill.
Origin: Kit's Scrawl capture of the pill (board card OCD-210).
Before: hovering the dev-server row draws a 2 px blue outline inside it.
After: the row shows the soft grey hover fill that every other menu uses.
What clicking a row should do (today it jumps the chat to the shell call, which shows no output) is a separate decision: D-38 on the board.
Visual
Read:
activity-chips.css. Checks: app typecheck and the activity chips component test pass. Argon review not run: no subagent tool in this session.