Skip to content

refactor(http): add context property to httpResource - #60188

Closed
JeanMeche wants to merge 1 commit into
angular:mainfrom
JeanMeche:http-context
Closed

refactor(http): add context property to httpResource#60188
JeanMeche wants to merge 1 commit into
angular:mainfrom
JeanMeche:http-context

Conversation

@JeanMeche

Copy link
Copy Markdown
Member

This was an oversight, context can be supported out of the box.

@JeanMeche
JeanMeche requested a review from alxhub March 3, 2025 16:19
@JeanMeche JeanMeche added area: common/http Issues related to HTTP and HTTP Client target: patch This PR is targeted for the next patch release labels Mar 3, 2025
@ngbot ngbot Bot added this to the Backlog milestone Mar 3, 2025
@pullapprove
pullapprove Bot requested review from atscott and kirjs March 3, 2025 16:30

@pkozlowski-opensource pkozlowski-opensource left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Reviewed-for: public-api

Comment thread packages/common/http/src/resource_api.ts Outdated
@pullapprove
pullapprove Bot requested a review from AndrewKushnir March 4, 2025 15:43

@kirjs kirjs left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed-for: public-api

This was an oversight, `context` can be supported out of the box.
@JeanMeche JeanMeche added the action: merge The PR is ready for merge by the caretaker label Mar 4, 2025
@mmalerba

mmalerba commented Mar 4, 2025

Copy link
Copy Markdown
Contributor

This PR was merged into the repository by commit bb14fe8.

The changes were merged into the following branches: main, 19.2.x

@mmalerba mmalerba closed this in bb14fe8 Mar 4, 2025
mmalerba pushed a commit that referenced this pull request Mar 4, 2025
This was an oversight, `context` can be supported out of the box.

PR Close #60188
@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Apr 4, 2025
@JeanMeche
JeanMeche deleted the http-context branch August 8, 2025 06:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: common/http Issues related to HTTP and HTTP Client target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants