Skip to content

fix(@angular/cli): disable update notifier when retrieving package manager version during ng version #21184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alan-agius4 merged 1 commit into from
Jun 25, 2021
+10 −1
Merged

fix(@angular/cli): disable update notifier when retrieving package manager version during ng version #21184

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion packages/angular/cli/commands/version-impl.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,16 @@ export class VersionCommand extends Command<VersionCommandSchema> {
private async getPackageManager(): Promise<string> {
try {
const manager = await getPackageManager(this.context.root);
const version = execSync(`${manager} --version`, { encoding: 'utf8', stdio: 'pipe' }).trim();
const version = execSync(`${manager} --version`, {
encoding: 'utf8',
stdio: ['ignore', 'pipe', 'ignore'],
env: {
...process.env,
// NPM updater notifier will prevents the child process from closing until it timeout after 3 minutes.
NO_UPDATE_NOTIFIER: '1',
NPM_CONFIG_UPDATE_NOTIFIER: 'false',
},
}).trim();

return `${manager} ${version}`;
} catch {
Expand Down