java.lang.IllegalArgumentException: Out of range: 4972007364548

[360060316]

Version

Media3 1.8.0

More version details

No response

Devices that reproduce the issue

xiaomi 11p、Hisense VIDAA_TV、Samsung SM-A5360

Devices that do not reproduce the issue

No response

Reproducible in the demo app?

Yes

Reproduction steps

play video

Expected result

java.lang.IllegalArgumentException

Actual result

java.lang.IllegalArgumentException: Out of range: 4972007364548
at com.google.common.base.Preconditions.checkArgument(Preconditions.java:204)
at com.google.common.primitives.Ints.checkedCast(Ints.java:88)
at androidx.media3.common.util.Util.percentInt(Util.java:1239)
at androidx.media3.common.BasePlayer.getBufferedPercentage(BasePlayer.java:324)
at com.jizhi.exo.ExoMediaPlayer$1.onPlaybackStateChanged(ExoMediaPlayer.java:5)
at androidx.media3.exoplayer.ExoPlayerImpl.lambda$updatePlaybackInfo$23(ExoPlayerImpl.java:2212)
at androidx.media3.exoplayer.ExoPlayerImpl.$r8$lambda$E4n58CkvitW_uqvjUINIEQVgh4g(ExoPlayerImpl.java:0)
at androidx.media3.exoplayer.ExoPlayerImpl$$ExternalSyntheticLambda11.invoke(ExoPlayerImpl.java:0)
at androidx.media3.common.util.ListenerSet$ListenerHolder.invoke(ListenerSet.java:342)
at androidx.media3.common.util.ListenerSet.lambda$queueEvent$0(ListenerSet.java:226)
at androidx.media3.common.util.ListenerSet.$r8$lambda$Maws-DUsVhcg5uFQgolq5mcQJiM(ListenerSet.java:0)
at androidx.media3.common.util.ListenerSet$$ExternalSyntheticLambda1.run(ListenerSet.java:0)
at androidx.media3.common.util.ListenerSet.flushEvents(ListenerSet.java:248)
at androidx.media3.exoplayer.ExoPlayerImpl.updatePlaybackInfo(ExoPlayerImpl.java:2242)
at androidx.media3.exoplayer.ExoPlayerImpl.handlePlaybackInfo(ExoPlayerImpl.java:2076)
at androidx.media3.exoplayer.ExoPlayerImpl.lambda$new$1(ExoPlayerImpl.java:353)
at androidx.media3.exoplayer.ExoPlayerImpl.$r8$lambda$lw6lhDmtFnjAs6VzxoaBDEG3RGo(ExoPlayerImpl.java:0)
at androidx.media3.exoplayer.DefaultSuitableOutputChecker$ImplApi23$$ExternalSyntheticLambda3.run(DefaultSuitableOutputChecker.java:0)
at android.os.Handler.handleCallback(Handler.java:751)
at android.os.Handler.dispatchMessage(Handler.java:95)
at android.os.Looper.loop(Looper.java:154)
at android.app.ActivityThread.main(ActivityThread.java:6103)
at java.lang.reflect.Method.invoke(Method.java)
at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:925)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:813)

Media

unknown

Bug Report

• You will email the zip file produced by adb bugreport to android-media-github@google.com after filing this issue.

[icbaker]

I think this can only happen if player.getBufferedPosition() returns a value much larger than player.getDuration(). Specifically for this case where:

(player.getBufferedPosition() * 100) / player.getDuration() = 4972007364548

An example of two values that achieve this are:

player.getBufferedPosition() = 1243001841137ms = 39 years
player.getDuration = 25ms

It seems unlikely that the player has actually got 39 years of media buffered in memory, so I think there must be a different root cause here. If you are able to reproduce the issue we can look into this separately (please file a new issue).

Before a9c0349 which switched to use the Util.percentInt method, the code in BasePlayer looked like:

Util.constrainValue((int) ((position * 100) / duration), 0, 100);

If we plug in our example numbers from above:

1243001841137 * 100 / 25 = 4972007364548

// overflow when casting from long to int"
(int) 4972007364548 = -1564764220

constrainValue(-1564764220, 0, 100) = 0

Which means this method was likely misbehaving in this situation before (by returning 0 due to an overflow) - and the change linked above transformed this into a crash.

I will modify Util.percentInt to use Ints.saturatedCast instead of checkedCast, which will stop the crash and result in the method returning 100% instead of 0% (which seems more correct for this case of a very large position and a very small duration).

[icbaker]

This is fixed by the commit linked above.