alsaseq: fix 'ext' buffer fill #3
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `GETDICTEXT` macro used to perfom one pass on the provided int list to check the actual item types brefore allocating and filling the target buffer. The python list was not read again causing the buffer to be filled with the last value read during the type check. This patch performs the type check as well as buffer fill in one go. The buffer is freed if an item is found to be of a wrong type.
|
I confirm without this PR pyalsa is not able to send sysex events (tested on python3). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
GETDICTEXTmacro used to perfom one pass on the provided intlist to check the actual item types brefore allocating and filling
the target buffer. The python list was not read again causing the
buffer to be filled with the last value read during the type check.
This patch performs the type check as well as buffer fill in one go.
The buffer is freed if an item is found to be of a wrong type.