Skip to content

build: disable rocksdb -march=native#183

Merged
feihongxu0824 merged 1 commit intomainfrom
build-rocksdb-no-native
Feb 28, 2026
Merged

build: disable rocksdb -march=native#183
feihongxu0824 merged 1 commit intomainfrom
build-rocksdb-no-native

Conversation

@egolearner
Copy link
Collaborator

No description provided.

@greptile-apps
Copy link

greptile-apps bot commented Feb 28, 2026

Greptile Summary

This PR adds the PORTABLE ON flag to RocksDB's CMake configuration, which disables the -march=native compiler flag. This ensures the RocksDB library is built in a portable manner that can run on different CPU architectures, rather than being optimized specifically for the build machine's architecture.

  • Prevents potential runtime crashes on systems with different CPU instruction sets
  • Aligns with the project's existing architecture-specific build strategy in cmake/option.cmake
  • Standard practice for distributable software that needs cross-platform compatibility

Confidence Score: 5/5

  • This PR is safe to merge with no risk
  • Single-line build configuration change using a standard RocksDB flag that improves portability without affecting functionality
  • No files require special attention

Important Files Changed

Filename Overview
thirdparty/rocksdb/CMakeLists.txt Adds PORTABLE ON flag to disable -march=native in RocksDB build, improving binary portability across different CPU architectures

Last reviewed commit: a659a6d

@egolearner egolearner changed the title build: disable rocksdb -arch=native build: disable rocksdb -march=native Feb 28, 2026
@feihongxu0824 feihongxu0824 merged commit 5e637bc into main Feb 28, 2026
9 checks passed
@feihongxu0824 feihongxu0824 deleted the build-rocksdb-no-native branch February 28, 2026 03:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants