Conversation
Add missing build dependencies and suppress expected monorepo warnings: - Add @babel/core and @types/react to @visx/demo dependencies (required by babel-loader and @react-spring/web respectively) - Add @babel/core to @visx/vendor devDependencies (required by @babel/plugin-transform-modules-commonjs) - Configure logFilters in .yarnrc.yml to suppress monorepo peer dependency warnings for react, react-dom, @react-spring/web, and webpack
There was a problem hiding this comment.
Pull Request Overview
This PR adds missing dependencies to package configuration files and configures Yarn log filtering. It addresses dependency management issues by explicitly declaring @babel/core and @types/react where they are used, and suppresses unhelpful peer dependency warnings in the Yarn configuration.
- Added explicit
@babel/coredependency declarations to packages that use Babel tooling - Added
@types/reactto the visx-demo package for proper TypeScript typing - Configured Yarn log filters to suppress noisy peer dependency warnings
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/visx-vendor/package.json | Added @babel/core ^7.22.5 to devDependencies for Babel plugin usage |
| packages/visx-demo/package.json | Added @babel/core ^7.26.0 and @types/react ^18.3.26 to dependencies |
| yarn.lock | Updated lockfile to reflect the new dependency declarations |
| .yarnrc.yml | Added log filters to suppress peer dependency warnings |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
🎉 This PR is included in version |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🏠 Internal