Skip to content

Conversation

@layday
Copy link
Contributor

@layday layday commented Apr 1, 2025

… from inspect (#10634)

(cherry picked from commit 77ad7d7)

What do these changes do?

Replace asyncio.iscoroutinefunction with inspect.iscoroutinefunction

asyncio.iscoroutinefunction was deprecated in python/cpython#122875.

Are there changes in behavior for the user?

No.

Is it a substantial burden for the maintainers to support this?

No.

Related issue number

None.

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • Add a new news fragment into the CHANGES/ folder
    • name it <issue_or_pr_num>.<type>.rst (e.g. 588.bugfix.rst)

    • if you don't have an issue number, change it to the pull request
      number after creating the PR

      • .bugfix: A bug fix for something the maintainers deemed an
        improper undesired behavior that got corrected to match
        pre-agreed expectations.
      • .feature: A new behavior, public APIs. That sort of stuff.
      • .deprecation: A declaration of future API removals and breaking
        changes in behavior.
      • .breaking: When something public is removed in a breaking way.
        Could be deprecated in an earlier release.
      • .doc: Notable updates to the documentation structure or build
        process.
      • .packaging: Notes for downstreams about unobvious side effects
        and tooling. Changes in the test invocation considerations and
        runtime assumptions.
      • .contrib: Stuff that affects the contributor experience. e.g.
        Running tests, building the docs, setting up the development
        environment.
      • .misc: Changes that are hard to assign to any of the above
        categories.
    • Make sure to use full sentences with correct case and punctuation,
      for example:

      Fixed issue with non-ascii contents in doctest text files
      -- by :user:`contributor-gh-handle`.

      Use the past tense or the present tense a non-imperative mood,
      referring to what's changed compared to the last released version
      of this project.

@codspeed-hq
Copy link

codspeed-hq bot commented Apr 1, 2025

CodSpeed Performance Report

Merging #10664 will not alter performance

Comparing layday:patchback/backports/3.12/77ad7d7ea173eda1306297d275b2d5f7348f9f60/pr-10634 (28d77b5) with 3.12 (710b64e)

Summary

✅ 51 untouched benchmarks

@codecov
Copy link

codecov bot commented Apr 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.10%. Comparing base (710b64e) to head (28d77b5).
Report is 201 commits behind head on 3.12.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             3.12   #10664      +/-   ##
==========================================
+ Coverage   97.79%   98.10%   +0.30%     
==========================================
  Files         126      126              
  Lines       37600    37601       +1     
  Branches     2132     2132              
==========================================
+ Hits        36772    36887     +115     
+ Misses        649      545     -104     
+ Partials      179      169      -10     
Flag Coverage Δ
CI-GHA 97.98% <100.00%> (+0.28%) ⬆️
OS-Linux 97.68% <100.00%> (+0.01%) ⬆️
OS-Windows 94.75% <85.71%> (?)
OS-macOS 96.81% <100.00%> (+<0.01%) ⬆️
Py-3.10.11 96.70% <100.00%> (+0.28%) ⬆️
Py-3.10.16 97.27% <100.00%> (+<0.01%) ⬆️
Py-3.11.11 97.33% <100.00%> (+0.62%) ⬆️
Py-3.11.9 96.81% <100.00%> (+0.28%) ⬆️
Py-3.12.9 97.77% <100.00%> (+1.15%) ⬆️
Py-3.13.2 97.76% <100.00%> (+0.29%) ⬆️
Py-3.9.13 96.58% <85.71%> (+0.28%) ⬆️
Py-3.9.21 97.14% <85.71%> (+0.68%) ⬆️
Py-pypy7.3.16 83.36% <71.42%> (?)
VM-macos 96.81% <100.00%> (+<0.01%) ⬆️
VM-ubuntu 97.68% <100.00%> (+0.01%) ⬆️
VM-windows 94.75% <85.71%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Dreamsorcerer Dreamsorcerer merged commit 83a9df5 into aio-libs:3.12 Apr 1, 2025
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bot:chronographer:provided There is a change note present in this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants