Repository navigation
docs(agents): document agent trace golden path - #10869
ishandhanani wants to merge 5 commits into
Conversation
Signed-off-by: Ishan Dhanani <ishandhanani@gmail.com>
Signed-off-by: Ishan Dhanani <ishandhanani@gmail.com>
Signed-off-by: Ishan Dhanani <ishandhanani@gmail.com>
| jq -c ' | ||
| select(.event.event_type == "request_end") | ||
| | {request_id: .event.request.request_id, agent_context: .event.agent_context} | ||
| ' | \ | ||
| head |
There was a problem hiding this comment.
🟡 Incorrect jq field paths in example command - .event. prefix doesn't match flat JSONL record schema
The jq command in docs/agents/agent-replay.md uses .event.event_type, .event.request.request_id, and .event.agent_context, implying the JSON records have an event wrapper object. However, the actual RequestTraceRecord serialization format (confirmed by the test data in lib/bench/src/request_trace/load.rs:446) is flat: fields like event_type, agent_context, and request are top-level keys. The correct jq paths should be .event_type, .request.request_id, and .agent_context. As written, the select filter will never match anything because .event will be null, so the command silently produces no output.
Test data showing flat record format (load.rs:446)
{"schema":"dynamo.request.trace.v1","event_type":"request_end","event_time_unix_ms":1100,"event_source":"dynamo","agent_context":{"trajectory_id":"root"},"request":{"request_id":"req-1",...}}
Was this helpful? React with 👍 or 👎 to provide feedback.
WalkthroughDocumentation restructuring: the agent-replay guide is substantially rewritten to cover both DynoSim offline and AIPerf live-endpoint replay paths. A new ChangesAgent Replay and Trace Format Documentation Restructure
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
…ntic-simulation-docs Signed-off-by: Ishan Dhanani <ishandhanani@gmail.com> # Conflicts: # docs/agents/agent-replay.md # docs/dynosim/runs.md
Signed-off-by: Ishan Dhanani <ishandhanani@gmail.com>
There was a problem hiding this comment.
🚩 Pre-existing ../../ escape link in unchanged runs.md line 69
The link at docs/dynosim/runs.md:69 — [\lib/mocker/src/replay/offline/README.md`](../../lib/mocker/src/replay/offline/README.md)— uses a relative../../path that escapesdocs/. Per docs/AGENTS.mdand the documentation style guide, targets outsidedocs/` should use absolute GitHub URLs. This is pre-existing and not part of the PR diff, but it's in the same file that this PR edits.
(Refers to line 69)
Was this helpful? React with 👍 or 👎 to provide feedback.
There was a problem hiding this comment.
🚩 Pre-existing SPDX header uses single year 2026 instead of range 2025-2026 in runs.md
The SPDX header at docs/dynosim/runs.md:2 uses Copyright (c) 2026 rather than the required range Copyright (c) 2025-2026. The documentation style guide mandates the 2025-2026 range. This is pre-existing (not touched by this PR) but is in the same file that was modified.
(Refers to line 2)
Was this helpful? React with 👍 or 👎 to provide feedback.
|
Closing in favor of a smaller replacement PR focused only on the replay guide. |
Documents an end-to-end path from a live Dynamo agent workload to offline DynoSim and live AIPerf replay. The guide makes request-DAG construction, fixed-schedule gating, cache-hash scope, and replay fidelity limits explicit.
CLOSES: DYN-3248
How This Was Implemented
DYN_REQUEST_TRACE, DynoSim, and AIPerf.Walkthrough
flowchart LR E["Live Dynamo endpoint"] --> T["Dynamo request trace"] T --> D["DynoSim offline replay"] T --> W["AIPerf Weka conversion"] W --> L["Live Dynamo replay"]Validation
pre-commit run --files docs/agents/agent-replay.md docs/dynosim/trace-formats.md docs/dynosim/runs.mdfern check(0 errors)fern docs broken-linksBenchmark Results
Summary
Adds one entry point for capturing and replaying agent workloads with offline DynoSim or live AIPerf. This keeps capture, format, and execution guidance separate while making the end-to-end path discoverable.
CLOSES: DYN-3248
agent_trace_to_mooncakecommandDependency
Walkthrough
docs/agents/agent-replay.md: choose offline or live replay, capture a request trace, convert it, run a smoke test, and understand the inferred request DAG.docs/dynosim/trace-formats.md: compare capture sources, consumers, schemas, block-size handling, and replay constraints.Validation
fern check: 0 errors.fern docs broken-links: passed.Summary by CodeRabbit