Switch to Gradle, JUnit5, and enable IntelliJ #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
koppor
pushed a commit
to adr/adr-j
that referenced
this pull request
Aug 18, 2019
Switch to Gradle, JUnit5, and enable IntelliJ
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am maintaining the adr language MADR and tried to get MADR support to adr-tools at npryce/adr-tools#43. However, this is not easily possible. Therefore, I am trying to reimplement the adr-tools. Thereby, I found adr-jr 🎉
This PR is a start to modernize to code base a bit.
I updated to gradle, since we successfully applied it in JabRef.
The code was reformatted using Ctrl + Shift + L in IntelliJ without any more configuration of code style.
I updated from JUnit4 to JUnit5 as JUnit5 is more modern and maybe the tests can be improved more easily (refs #2).