This repository was archived by the owner on Sep 6, 2021. It is now read-only.
Explicitly check for mac platform before using Cmd key for Ctrl in shortcuts #1134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
This fixes all of the unit test on windows and most of the tests on the mac. I'm still seeing one error in the Menus tests on the mac. |
…ng it to be Cmd-9 on Mac, but I need to get the platform information to check it conditionally.
Member
|
Tests all pass now. Could you file a bug to fix the menu tests? Ideally we would check for mac and windows bindings for newly-created menu items. |
gruehle
added a commit
that referenced
this pull request
Jun 24, 2012
Explicitly check for mac platform before using Cmd key for Ctrl in shortcuts
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix KeyBindingManager unit test failed issue #1132