Fix Empty Cache save when the path is github workspace directory #1132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please check the failing test cases? |
… current directory
tiwarishub
approved these changes
Jul 26, 2022
|
I'll create a separate PR for npm audit fix. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the #833 issue in actions/cache.
Issue Summary: Cache being saved is empty in case of path being current directory or github.workspace. So github.workspace directory can never get cached.
Root cause: The resolvePaths function returns empty since the relative path of the path provided in cache's path param is calculated against the workspace directory itself.
Resolution: We manually add '.' to paths list since the list will be empty in the above scenario.
Feedback is welcome regarding the implementation and possible alternatives. 👀