chore(logs): add more logs and better dry-run #463
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 24, 2021
luketomlinson
requested changes
Jun 2, 2021
Collaborator
luketomlinson
left a comment
There was a problem hiding this comment.
Maybe I'm reading it incorrectly, but I think some conditions might be swapped? I'd appreciate any explanation if I'm missing something 😅
A log was missing when the option was configured but the close label was not present on the issue/PR Change the log about not removing the close label to explicitly mention that this behaviour occur because the option is not configured Fixes actions#462
the dry-run checks were cancelling way sooner the workflow the logs and the count of operations could not occur in dry run due to this the goal of the dry run is just to skip some logic regarding the api calls to avoid altering the repos but the goal IMO is to also make them reflect the real world run so this change allow this BTW it also allow now to test the consumed operations Fixes actions#461
Contributor
Author
|
@luketomlinson nice catch, thanks! |
luketomlinson
approved these changes
Jun 7, 2021
This was referenced Jun 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FYI, you can read the commits to have a better description.
Changes
Closes #462
Closes #461