update go imports

[stephenwithav]

Closes #19

[ChristopherHX]

You should have used my branch #17 ?

The import order is fixed there, by adding spaces etc. Only the single test fails

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
cmd/root.go	0.00%	1 Missing ⚠️
pkg/container/docker_run.go	0.00%	1 Missing ⚠️

Files with missing lines	Coverage Δ
cmd/graph.go	0.00% <ø> (ø)
cmd/list.go	0.00% <ø> (ø)
main.go	0.00% <ø> (ø)
pkg/artifactcache/handler.go	68.40% <ø> (ø)
pkg/artifacts/server.go	68.08% <ø> (ø)
pkg/common/git/git.go	65.72% <ø> (ø)
pkg/container/docker_auth.go	51.35% <ø> (ø)
pkg/container/docker_build.go	71.25% <ø> (ø)
pkg/container/docker_network.go	50.00% <ø> (ø)
pkg/container/docker_pull.go	65.16% <ø> (ø)
... and 28 more

[ChristopherHX]

Your change is better by keeping the tests working, but mine has passing lint.

codecov/patch can be overriden, the cmd package has zero coverage needed

[ChristopherHX]

Feel free to merge yours while I'm offline 👍

[stephenwithav]

Apologies, @ChristopherHX. I spent a couple of hours (mostly CI) on #17 and couldn't get it to work locally, so I started fresh to see if I could get the CI to pass.

[stephenwithav]

Interesting. The Linux test succeeds on GitHub if the linter fails, but not if it succeeds. I'm going to break the linter again and see if that's reproducible.

I'm getting 37 failures locally. Lots more referencing https://github.com/nektos/act-test-action. Should that be migrated?

[ChristopherHX]

Lots more referencing https://github.com/nektos/act-test-action. Should that be migrated?

We could merge them into this repo, via LocalRepository redirect.
I will look into that.

The Linux test succeeds on GitHub if the linter fails, but not if it succeeds

The tests are currently fragile, sometimes they fail in CI due to unrelated reasons even if they could pass.

I will look also again into this

[ChristopherHX]

Hmm maybe my now enabled GoGitActionCache has a bug, had rerun the previous commit with a single failed test

[ChristopherHX]

So many non deterministic failures...

• 136 sigkill again
• logger bug concurrent write #23
• go bug strings.Index fails randomly? #10

Idk why, this cannot be the package rename...

Reapplied your previous commit

[ChristopherHX]

If it still fails, I remove actions/cache from the test workflow. The log spam makes the GitHub Actions Infra behave like running out of resources, because it takes a log to notify the backend that the next step is running

[ChristopherHX]

codecov, needs more excludes merge