fix(actions): pass the MSK IAM oauth_cb to the actions pod - #731
Merged
Merged
Conversation
With global.kafka.iam.enabled the actions pod gets SASL_SSL, OAUTHBEARER and sasl.oauthbearer.method=default, but no token callback, so librdkafka has no way to obtain an MSK IAM token. Set KAFKA_PROPERTIES_OAUTH_CB to the callback shipped in the actions image (datahub_actions.utils.kafka_msk_iam:oauth_cb). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
4 of 5 tasks
david-leifker
approved these changes
Sep 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
With
global.kafka.iam.enabled: true, the actions pod receivesKAFKA_PROPERTIES_SECURITY_PROTOCOL=SASL_SSL,KAFKA_PROPERTIES_SASL_MECHANISM=OAUTHBEARERandKAFKA_PROPERTIES_SASL_OAUTHBEARER_METHOD=default, but no token callback. librdkafka then has no way to get an MSK IAM token. This PR addsKAFKA_PROPERTIES_OAUTH_CB=datahub_actions.utils.kafka_msk_iam:oauth_cb, which points at the callback shipped in the actions image.This pairs with datahub-project/datahub#20104, which makes the actions Kafka event source read
KAFKA_PROPERTIES_*. On actions images from before that change, the variable is ignored and harmless.The rest of the Kafka auth wiring already matches what the chart gives its other Kafka consumers:
springKafkaConfigurationOverridesandcredentialsAndCertsSecrets.secureEnv, including secret-backed values. The only gap was the IAM callback.Render (
global.kafka.iam.enabled: true,awsRegion: us-west-2)With IAM disabled,
KAFKA_PROPERTIES_OAUTH_CBis not rendered.Chart versions:
acryl-datahub-actions0.3.11 → 0.3.12,datahub1.1.5 → 1.1.6.Checklist
🤖 Generated with Claude Code