Skip to content

Conversation

@oh2024
Copy link
Collaborator

@oh2024 oh2024 commented Apr 19, 2024

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
  1. Add username/password authentication to tablet servers
  2. Added skip_grant_tables flag to disable auth
  • What is the current behavior? (You can also link to an open issue here)
    Tablet servers have only service-auth enabled, trusting the sdefault token.

  • What is the new behavior (if this is a feature change)?
    Tablet servers will use the username and password from the user table for authentication

@codecov
Copy link

codecov bot commented Apr 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.22%. Comparing base (99c179e) to head (6962c8e).
Report is 6 commits behind head on main.

Additional details and impacted files
@@              Coverage Diff              @@
##               main    #3885       +/-   ##
=============================================
- Coverage     75.13%   41.22%   -33.92%     
  Complexity      658      658               
=============================================
  Files           753      197      -556     
  Lines        135134    11805   -123329     
  Branches       1978     1979        +1     
=============================================
- Hits         101538     4867    -96671     
+ Misses        33292     6634    -26658     
  Partials        304      304               

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 19, 2024

Linux Test Report

    59 files     252 suites   1h 43m 16s ⏱️
13 509 tests 13 502 ✅ 7 💤 0 ❌
19 181 runs  19 174 ✅ 7 💤 0 ❌

Results for commit dece628.

♻️ This comment has been updated with latest results.

@github-actions github-actions bot removed build openmldb compiling and installing batch-engine openmldb batch(offline) engine labels Apr 22, 2024
@oh2024 oh2024 changed the title feat: support tablet auth feat: support tablet auth and flag to disable auth Apr 23, 2024
Copy link
Collaborator

@vagetablechicken vagetablechicken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add doc:

  • how to use flag in server side, which servers, need restart
  • how to use in client side, which clients, need restart

Release test should follow the steps in doc.

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Apr 24, 2024
@vagetablechicken
Copy link
Collaborator

vagetablechicken commented Apr 24, 2024

add doc:

  • how to use flag in server side, which servers, need restart
  • how to use in client side, which clients, need restart

Release test should follow the steps in doc.

是不是所有server和client(java python cli)都能用这个开关
这个开关是090才有,更早的版本不要用。
这个开关打开要重启生效。
server不打开,client打开是什么样。部分server打开,是什么样。
认证错误,客户端收到的错误是什么样的

Copy link
Collaborator

@tobegit3hub tobegit3hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tobegit3hub tobegit3hub removed the request for review from aceforeverd April 25, 2024 03:31
@tobegit3hub tobegit3hub merged commit c2d9c8d into 4paradigm:main Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation storage-engine openmldb storage engine. nameserver & tablet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants