Bug 305531 - Review Request: bluecurve-gdm-theme - Bluecurve GDM theme
Summary: Review Request: bluecurve-gdm-theme - Bluecurve GDM theme
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
low
low
Target Milestone: ---
Assignee: Matthias Clasen
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: ArtworkSplit
TreeView+ depends on / blocked
 
Reported: 2007-09-25 17:05 UTC by Ray Strode [halfline]
Modified: 2007-11-30 22:12 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2007-10-11 15:39:27 UTC
Type: ---
Embargoed:
mclasen: fedora-review+
notting: fedora-cvs+


Attachments (Terms of Use)

Description Ray Strode [halfline] 2007-09-25 17:05:58 UTC
Spec URL:
http://rstrode.fedorapeople.org/bluecurve-gdm-theme/checkout/bluecurve-gdm-theme.spec

SRPM URL:
http://rstrode.fedorapeople.org/bluecurve-gdm-theme/checkout/bluecurve-gdm-theme-1.0.0-1.fc8.src.rpm

Description:
This package contains the classic Bluecurve GDM theme that was shipped in
late versions of Red Hat Linux and early versions of Fedora Core.

Comment 1 Matthias Clasen 2007-09-26 01:18:15 UTC
rpmlint is silent
package name: ok
spec file name: ok
packaging guidelines: ok
license: ok
license field: ok
license file: must be included
spec language: ok
spec readable: yes
upstream sources: no upstream yet
buildable: ok
ExcludeArch: n/a
BRs: must add perl(XML::Parser)
locales: ok
shared libs: n/a
relocatable: n/a
directory ownership: ok
%file: ok
permissions: ok
%clean: ok
macro use: ok
content: permissible
large docs: n/a
%doc: ok
header files: n/a
static libs: n/a
pc files: n/a
shared libs: n/a
devel package: n/a
libtool archives: n/a
gui apps: n/a
directory ownership: ok
%install: ok
utf8 filenames: ok


should the Requires: fedora-logos be Requires: system-logos instead ?



Comment 2 Ray Strode [halfline] 2007-09-26 03:12:12 UTC
adding COPYING and BuildRequires.  

We want fedora-logos because the theme is Fedora branded by design.  Well,
maybe.  The other gdm themes definitely.  Bluecurve is debatable actually.  What
do you think?

Comment 3 Bill Nottingham 2007-09-26 13:43:45 UTC
Well, it doesn't actually use a *trademarked* logo (this is just the old Fedora
font on a big blue background, right?)

Comment 4 Ray Strode [halfline] 2007-09-26 13:47:43 UTC
Okay, yea, let's make this one system-logos then.

Comment 5 Bill Nottingham 2007-09-26 14:01:27 UTC
No, I mean if it's not trademarked, you can just put the graphic in the theme.
Or leave it in fedora-logos, either or.

Comment 6 Ray Strode [halfline] 2007-09-26 14:11:00 UTC
ah right, that's even nicer

Comment 7 Ray Strode [halfline] 2007-09-26 21:02:41 UTC
I made the change suggested in comment 5, fwiw (and the similar change for the
kdm theme)

Comment 8 Matthias Clasen 2007-09-27 18:23:44 UTC
Approved

Comment 9 Ray Strode [halfline] 2007-10-09 15:59:20 UTC
New Package CVS Request
=======================
Package Name: bluecurve-gdm-theme
Short Description: Bluecurve-gdm-theme
Owners: rstrode,davidz
Branches:
InitialCC:
Cvsextras Commits: no

Comment 10 Bill Nottingham 2007-10-09 21:31:50 UTC
done


Note You need to log in before you can comment on or make changes to this bug.