* [gentoo-portage-dev] [PATCH 1/2] lib/_emerge/resolver/output.py: say 'soft blocking' explicitly
@ 2021-10-02 20:11 Sam James
2021-10-02 20:11 ` [gentoo-portage-dev] [PATCH 2/2] lib/_emerge/resolver/output_helpers.py: explicitly state 'all satisfied' Sam James
0 siblings, 1 reply; 4+ messages in thread
From: Sam James @ 2021-10-02 20:11 UTC (permalink / raw
To: gentoo-portage-dev; +Cc: Sam James
Before:
```
[blocks b ] >perl-core/Scalar-List-Utils-1.550.0-r999 (">perl-core/Scalar-List-Utils-1.550.0-r999" is blocking virtual/perl-Scalar-List-Utils-1.550.0)
```
After:
```
[blocks b ] >perl-core/Scalar-List-Utils-1.550.0-r999 (">perl-core/Scalar-List-Utils-1.550.0-r999" is soft blocking virtual/perl-Scalar-List-Utils-1.550.0)
```
This should make it a little bit clearer when a block matters,
especially given we already explicitly say 'hard blocking'
for the opposite case.
Signed-off-by: Sam James <sam@gentoo.org>
---
lib/_emerge/resolver/output.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/_emerge/resolver/output.py b/lib/_emerge/resolver/output.py
index e891d84c0..7b5602a78 100644
--- a/lib/_emerge/resolver/output.py
+++ b/lib/_emerge/resolver/output.py
@@ -108,7 +108,7 @@ class Display:
if blocker.atom.blocker.overlap.forbid:
blocking_desc = "hard blocking"
else:
- blocking_desc = "blocking"
+ blocking_desc = "soft blocking"
if self.resolved != blocker.atom:
addl += colorize(
self.blocker_style,
--
2.33.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [gentoo-portage-dev] [PATCH 2/2] lib/_emerge/resolver/output_helpers.py: explicitly state 'all satisfied'
2021-10-02 20:11 [gentoo-portage-dev] [PATCH 1/2] lib/_emerge/resolver/output.py: say 'soft blocking' explicitly Sam James
@ 2021-10-02 20:11 ` Sam James
2021-10-06 18:05 ` [gentoo-portage-dev] " Duncan
0 siblings, 1 reply; 4+ messages in thread
From: Sam James @ 2021-10-02 20:11 UTC (permalink / raw
To: gentoo-portage-dev; +Cc: Sam James
This makes things a bit less confusing and tries to avoid
users focusing on (soft) blocks which aren't actually
the problem they're hitting.
Signed-off-by: Sam James <sam@gentoo.org>
---
lib/_emerge/resolver/output_helpers.py | 2 ++
1 file changed, 2 insertions(+)
diff --git a/lib/_emerge/resolver/output_helpers.py b/lib/_emerge/resolver/output_helpers.py
index f80b79ccf..6ce812189 100644
--- a/lib/_emerge/resolver/output_helpers.py
+++ b/lib/_emerge/resolver/output_helpers.py
@@ -163,6 +163,8 @@ class _PackageCounters:
myoutput.append(
bad(" (%s unsatisfied)") % (self.blocks - self.blocks_satisfied)
)
+ else:
+ myoutput.append(" (all satisfied)")
return "".join(myoutput)
--
2.33.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [gentoo-portage-dev] Re: [PATCH 2/2] lib/_emerge/resolver/output_helpers.py: explicitly state 'all satisfied'
2021-10-02 20:11 ` [gentoo-portage-dev] [PATCH 2/2] lib/_emerge/resolver/output_helpers.py: explicitly state 'all satisfied' Sam James
@ 2021-10-06 18:05 ` Duncan
2021-10-07 2:39 ` [gentoo-portage-dev] " Sam James
0 siblings, 1 reply; 4+ messages in thread
From: Duncan @ 2021-10-06 18:05 UTC (permalink / raw
To: gentoo-portage-dev
Sam James posted on Sat, 2 Oct 2021 21:11:56 +0100 as excerpted:
> This makes things a bit less confusing and tries to avoid users focusing
> on (soft) blocks which aren't actually the problem they're hitting.
I was pleasantly surprised by that "all satisfied" earlier today.
Thanks. I could get my brain around the old format but this is /so/ much
nicer! =:^)
--
Duncan - List replies preferred. No HTML msgs.
"Every nonfree program has a lord, a master --
and if you use the program, he is your master." Richard Stallman
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [gentoo-portage-dev] [PATCH 2/2] lib/_emerge/resolver/output_helpers.py: explicitly state 'all satisfied'
2021-10-06 18:05 ` [gentoo-portage-dev] " Duncan
@ 2021-10-07 2:39 ` Sam James
0 siblings, 0 replies; 4+ messages in thread
From: Sam James @ 2021-10-07 2:39 UTC (permalink / raw
To: gentoo-portage-dev
[-- Attachment #1: Type: text/plain, Size: 549 bytes --]
> On 6 Oct 2021, at 19:05, Duncan <1i5t5.duncan@cox.net> wrote:
>
> Sam James posted on Sat, 2 Oct 2021 21:11:56 +0100 as excerpted:
>
>> This makes things a bit less confusing and tries to avoid users focusing
>> on (soft) blocks which aren't actually the problem they're hitting.
>
> I was pleasantly surprised by that "all satisfied" earlier today.
> Thanks. I could get my brain around the old format but this is /so/ much
> nicer! =:^)
>
Big thanks for giving this positive feedback! Great motivator :)
And glad it helped!
Best,
sam
[-- Attachment #2: Message signed with OpenPGP --]
[-- Type: application/pgp-signature, Size: 618 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-10-07 2:40 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-10-02 20:11 [gentoo-portage-dev] [PATCH 1/2] lib/_emerge/resolver/output.py: say 'soft blocking' explicitly Sam James
2021-10-02 20:11 ` [gentoo-portage-dev] [PATCH 2/2] lib/_emerge/resolver/output_helpers.py: explicitly state 'all satisfied' Sam James
2021-10-06 18:05 ` [gentoo-portage-dev] " Duncan
2021-10-07 2:39 ` [gentoo-portage-dev] " Sam James
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox