Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core(performance): hide most audits under passing conditions #16315

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

adamraine
Copy link
Member

Closes #16265

Several performance audits follow a pattern where they mark themselves as informative when there isn't a problem, instead of going into a true passing state (i.e. hidden in the "Passed audits" section). Although this pattern is necessary to keep audits like largest-contentful-paint-element visible, it's kinda overused which has led to some confusion as mentioned in #16265.

This PR removes the "informative on pass" pattern from most audits. The following audits will still use the "informative on pass" pattern because they contain critical information for CWV:

  • largest-contentful-paint-element
  • layout-shifts
  • work-during-interaction

Might be worth keeping the "informative on pass" pattern for third-party-summary since 3P payloads could still be high even in a passing state, but that's debatable.

@adamraine adamraine requested a review from a team as a code owner January 28, 2025 23:36
@adamraine adamraine requested review from connorjclark and removed request for a team January 28, 2025 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Questions regarding "Avoid enormous network payloads" audit
1 participant