-
Notifications
You must be signed in to change notification settings - Fork 17
Permalink
Choose a base ref
{{ refName }}
default
Choose a head ref
{{ refName }}
default
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
base repository: googleapis/java-shared-config
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.9.0
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
...
head repository: googleapis/java-shared-config
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.9.1
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
- 8 commits
- 4 files changed
- 4 contributors
Commits on Jun 29, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 8b98af5 - Browse repository at this point
Copy the full SHA 8b98af5View commit details
Commits on Jul 1, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 8fc9789 - Browse repository at this point
Copy the full SHA 8fc9789View commit details -
build(deps): update dependency org.apache.maven.plugins:maven-surefir…
…e-plugin to v3.0.0-m5 (#165)
Configuration menu - View commit details
-
Copy full SHA for b49d421 - Browse repository at this point
Copy the full SHA b49d421View commit details -
build(deps): update dependency org.apache.maven.plugins:maven-site-pl…
…ugin to v3.9.1 (#172)
Configuration menu - View commit details
-
Copy full SHA for 5a9c6eb - Browse repository at this point
Copy the full SHA 5a9c6ebView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9ab06b2 - Browse repository at this point
Copy the full SHA 9ab06b2View commit details -
fix: maven-dependency-plugin configuration breaking downstream config (…
…#174) When providing configuration to the maven-dependency-plugin, `ignoredUnusedDeclaredDependencies` is a `java.lang.String[]` but mavens xml handling allows multiple formats for providing a list of values (comma separated string, or sub elements each specifying a single value). It appears that when loading the config, the value of the configuration at a lower level is blindly pre-pended as a string rather than first parsing and merging the results. Below is the debug output of the resolved configuration using the existing config added in cd635ad, the output after this change and a diff of the two. Notice, in the left hand side of the diff the malformed xml. The change introduced in this commit switches from using the comma separated string representation, to using the sub element representation thereby allowing the config resolution to create a valid config. ###### Resolved config as of cd635ad ``` [DEBUG] Goal: org.apache.maven.plugins:maven-dependency-plugin:3.1.2:analyze (default-cli) [DEBUG] Style: Regular [DEBUG] Configuration: <?xml version="1.0" encoding="UTF-8"?> <configuration> <analyzer default-value="default">${analyzer}</analyzer> <baseDir default-value="${basedir}"/> <failOnWarning default-value="false">${failOnWarning}</failOnWarning> <ignoreNonCompile default-value="false">${ignoreNonCompile}</ignoreNonCompile> <ignoredUnusedDeclaredDependencies> <ignoredUnusedDeclaredDependency>com.google.http-client:google-http-client-jackson2</ignoredUnusedDeclaredDependency> <ignoredUnusedDeclaredDependency>com.google.oauth-client:google-oauth-client</ignoredUnusedDeclaredDependency> <ignoredUnusedDeclaredDependency>javax.annotation:javax.annotation-api</ignoredUnusedDeclaredDependency>javax.annotation:javax.annotation-api</ignoredUnusedDeclaredDependencies> <outputDirectory default-value="${project.build.directory}"/> <outputXML default-value="false">${outputXML}</outputXML> <project default-value="${project}"/> <scriptableFlag default-value="$$$%%%">${scriptableFlag}</scriptableFlag> <scriptableOutput default-value="false">${scriptableOutput}</scriptableOutput> <skip default-value="false">${mdep.analyze.skip}</skip> <verbose default-value="false">${verbose}</verbose> </configuration> ``` ###### Resolved config now ``` [DEBUG] Goal: org.apache.maven.plugins:maven-dependency-plugin:3.1.2:analyze (default-cli) [DEBUG] Style: Regular [DEBUG] Configuration: <?xml version="1.0" encoding="UTF-8"?> <configuration> <analyzer default-value="default">${analyzer}</analyzer> <baseDir default-value="${basedir}"/> <failOnWarning default-value="false">${failOnWarning}</failOnWarning> <ignoreNonCompile default-value="false">${ignoreNonCompile}</ignoreNonCompile> <ignoredUnusedDeclaredDependencies> <ignoredUnusedDeclaredDependency>com.google.http-client:google-http-client-jackson2</ignoredUnusedDeclaredDependency> <ignoredUnusedDeclaredDependency>com.google.oauth-client:google-oauth-client</ignoredUnusedDeclaredDependency> <ignoredUnusedDeclaredDependency>javax.annotation:javax.annotation-api</ignoredUnusedDeclaredDependency> </ignoredUnusedDeclaredDependencies> <outputDirectory default-value="${project.build.directory}"/> <outputXML default-value="false">${outputXML}</outputXML> <project default-value="${project}"/> <scriptableFlag default-value="$$$%%%">${scriptableFlag}</scriptableFlag> <scriptableOutput default-value="false">${scriptableOutput}</scriptableOutput> <skip default-value="false">${mdep.analyze.skip}</skip> <verbose default-value="false">${verbose}</verbose> </configuration> ``` ##### Diff between resolved configs ```diff 12c12,13 < <ignoredUnusedDeclaredDependency>javax.annotation:javax.annotation-api</ignoredUnusedDeclaredDependency>javax.annotation:javax.annotation-api</ignoredUnusedDeclaredDependencies> --- > <ignoredUnusedDeclaredDependency>javax.annotation:javax.annotation-api</ignoredUnusedDeclaredDependency> > </ignoredUnusedDeclaredDependencies> ```
Configuration menu - View commit details
-
Copy full SHA for 507217f - Browse repository at this point
Copy the full SHA 507217fView commit details -
chore: release 0.9.1-SNAPSHOT (#177)
🤖 I have created a release \*beep\* \*boop\* --- ### Updating meta-information for bleeding-edge SNAPSHOT release. --- This PR was generated with [Release Please](https://github.com/googleapis/release-please).
Configuration menu - View commit details
-
Copy full SHA for 63ed1a3 - Browse repository at this point
Copy the full SHA 63ed1a3View commit details -
🤖 I have created a release \*beep\* \*boop\* --- ### [0.9.1](https://www.github.com/googleapis/java-shared-config/compare/v0.9.0...v0.9.1) (2020-07-01) ### Bug Fixes * maven-dependency-plugin configuration breaking downstream config ([#174](https://www.github.com/googleapis/java-shared-config/issues/174)) ([507217f](https://www.github.com/googleapis/java-shared-config/commit/507217fe509cd4f16eb50c8075ab43229238e08d)) ### Documentation * change Devsite output path to /java/docs/reference ([#176](https://www.github.com/googleapis/java-shared-config/issues/176)) ([8b98af5](https://www.github.com/googleapis/java-shared-config/commit/8b98af54bf503d97bb86b6d02a5c4301b39384e1)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please).
Configuration menu - View commit details
-
Copy full SHA for 60c03c8 - Browse repository at this point
Copy the full SHA 60c03c8View commit details
Loading
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v0.9.0...v0.9.1