Skip to content

"Make libprotobuf symbols local on OSX" - fix missing #9395

Closed
@peteboothroyd

Description

@peteboothroyd

The initial problem is described here. The current issue is that a piper import issue has caused the fix to be removed, meaning that the problem has been reintroduced. The import issue is discussed further here. This issue is opened to track the reintroduction of the fix.

Perhaps part of the issue is that there wasn't an associated test added to verify that only a limited subset of all the available symbols were exposed in the resulting dylib. I'm not sure how/if this is possible in the current wheel building pipeline.

What version of protobuf and what language are you using?
Version: All versions as far as I know.
Language: Python

What operating system (Linux, Windows, ...) and version? macOS

What did you expect to see

The fix introduced in #8346 should be present in the setup.py file.

What did you see instead?

The fix has been removed.

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions