-
Notifications
You must be signed in to change notification settings - Fork 3.9k
bom: Remove protoc-gen-grpc-java #9020
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
protoc-gen-grpc-java isn't useful in a BOM because the Gradle plugin doesn't support BOMs (google/protobuf-gradle-plugin#412) and it seems unlikely the Maven plugin would as well. Right now the type is pom, which is useless; nobody cares about the pom itself. We'd need to use a type of exe and repeat it for each platform (classifier). Given that it is a strange case and we can't actually test the results and having it in the bom might lead a user to trying to make it work, let's just remove it for now until it provides value. Fixes grpc#8936
👍 This would break the build for maven projects that have a (useless) dependency on <dependencyManagement>
<dependencies>
<dependency>
<groupId>io.grpc</groupId>
<artifactId>grpc-bom</artifactId>
<version>1.45.0</version>
<scope>import</scope>
<type>pom</type>
</dependency>
</dependencies>
</dependencyManagement>
<dependencies>
<dependency>
<groupId>io.grpc</groupId>
<artifactId>protoc-gen-grpc-java</artifactId>
<type>pom</type>
</dependency>
</dependencies> They would then get the following error if we remove
Hopefully this is rare in the wild. I did not find any such users in our internal index. |
Yeah, that should be rare and should only break on a version upgrade, at which point the solution is "delete the useless dependency that does nothing." So I'm not very concerned. |
FFR: I used the version from the bom in my gradle project and v1.46.0 broke the ci build.
IMO its a bug in the maven plugin that it doesn't use the version from the bom. |
@ST-DDT, I mention I didn't think it worked for gradle as well and linked to an issue. Looks like you are using dependencyManagement in buildscript. Interesting. We'll revert this. |
protoc-gen-grpc-java isn't useful in a BOM because the Gradle plugin
doesn't support BOMs (google/protobuf-gradle-plugin#412) and it seems
unlikely the Maven plugin would as well.
Right now the type is pom, which is useless; nobody cares about the pom
itself. We'd need to use a type of exe and repeat it for each platform
(classifier). Given that it is a strange case and we can't actually test
the results and having it in the bom might lead a user to trying to make
it work, let's just remove it for now until it provides value.
Fixes #8936