rls: fix routeLookupClient may be null in RlsLoadBalancer.requestConnection() #8379
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dapengzhang0
reviewed
Aug 5, 2021
| @@ -185,7 +185,7 @@ private void handleClusterDiscovered() { | |||
| } | |||
| LoadBalancerProvider lbProvider = null; | |||
| Object lbConfig = null; | |||
| if (root.result.lbPolicy() == LbPolicy.RING_HASH) { | |||
| if (root.result != null && root.result.lbPolicy() == LbPolicy.RING_HASH) { | |||
There was a problem hiding this comment.
If root.result is null, then because of the above code, the queue is immediately emptied and instances is also empty, and because instances is empty, the code won't reach here.
3e1455f to
d09ba22
Compare
|
Ok, how about this? |
@skyguard1 You did find a bug. Thanks! |
dapengzhang0
approved these changes
Aug 6, 2021
|
@dapengzhang0 It is my pleasure |
|
@dapengzhang0 Thanks |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ClusterState.result may be null inCdsLoadBalancer2,can add not-null check to result to avoid NullPointerException, thanksrouteLookupClientmay be null inRlsLoadBalancer.requestConnection()