Skip to content

Commit eff00fb

Browse files
authored
fix: remove PCU internals which should be hidden (#2263)
1 parent c5274ce commit eff00fb

File tree

2 files changed

+19
-3
lines changed

2 files changed

+19
-3
lines changed

google-cloud-storage/clirr-ignored-differences.xml

+16
Original file line numberDiff line numberDiff line change
@@ -15,4 +15,20 @@
1515
<method>* writeAndClose(*)</method>
1616
</difference>
1717

18+
<!-- @BetaApi members -->
19+
<difference>
20+
<differenceType>7009</differenceType>
21+
<className>com/google/cloud/storage/ParallelCompositeUploadBlobWriteSessionConfig$PartCleanupStrategy</className>
22+
<method>boolean isDeleteAllOnError()</method>
23+
</difference>
24+
<difference>
25+
<differenceType>7009</differenceType>
26+
<className>com/google/cloud/storage/ParallelCompositeUploadBlobWriteSessionConfig$PartCleanupStrategy</className>
27+
<method>boolean isDeletePartsOnSuccess()</method>
28+
</difference>
29+
<difference>
30+
<differenceType>7009</differenceType>
31+
<className>com/google/cloud/storage/ParallelCompositeUploadBlobWriteSessionConfig$PartNamingStrategy</className>
32+
<method>java.lang.String fmtFields(*)</method>
33+
</difference>
1834
</differences>

google-cloud-storage/src/main/java/com/google/cloud/storage/ParallelCompositeUploadBlobWriteSessionConfig.java

+3-3
Original file line numberDiff line numberDiff line change
@@ -467,7 +467,7 @@ String fmtName(String ultimateObjectName, PartRange partRange) {
467467
return fmtFields(randomKey, nameDigest, partRange.encode());
468468
}
469469

470-
protected abstract String fmtFields(String randomKey, String nameDigest, String partRange);
470+
abstract String fmtFields(String randomKey, String nameDigest, String partRange);
471471

472472
/**
473473
* Default strategy in which no stable prefix is defined.
@@ -588,11 +588,11 @@ private PartCleanupStrategy(boolean deletePartsOnSuccess, boolean deleteAllOnErr
588588
this.deleteAllOnError = deleteAllOnError;
589589
}
590590

591-
public boolean isDeletePartsOnSuccess() {
591+
boolean isDeletePartsOnSuccess() {
592592
return deletePartsOnSuccess;
593593
}
594594

595-
public boolean isDeleteAllOnError() {
595+
boolean isDeleteAllOnError() {
596596
return deleteAllOnError;
597597
}
598598

0 commit comments

Comments
 (0)