Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(typescript): Check whether the method is abstract when checking is_overload #9678

Merged
merged 3 commits into from
Oct 25, 2024

Conversation

CPunisher
Copy link
Member

Description:

BREAKING CHANGE:

Related issue (if exists):
closes #9656

@CPunisher CPunisher requested a review from a team as a code owner October 24, 2024 12:50
Copy link

changeset-bot bot commented Oct 24, 2024

🦋 Changeset detected

Latest commit: 914b6c5

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@CPunisher
Copy link
Member Author

Copy link

codspeed-hq bot commented Oct 24, 2024

CodSpeed Performance Report

Merging #9678 will degrade performances by 3.59%

Comparing CPunisher:fix/dts-abstract-method (914b6c5) with main (b8d255b)

Summary

❌ 1 regressions
✅ 193 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main CPunisher:fix/dts-abstract-method Change
es/full/bugs-1 522.9 µs 542.4 µs -3.59%

@kdy1 kdy1 added this to the Planned milestone Oct 24, 2024
@kdy1
Copy link
Member

kdy1 commented Oct 25, 2024

Should we port the changes of denoland/deno_graph@main/src/fast_check?

It would be nice 👍

Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@kdy1 kdy1 merged commit 78500af into swc-project:main Oct 25, 2024
22 checks passed
@kdy1 kdy1 modified the milestones: Planned, 1.7.38 Oct 26, 2024
@swc-project swc-project locked as resolved and limited conversation to collaborators Nov 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

emitIsolatedDts fails to preserve subsequent function declaration after abstract function conversion
2 participants