fix: Remove type-only import x = y.z

[liuxingbaoyu]

Q	A
Fixed Issues?	Fixes #15942
Patch: Bug Fix?	√
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass?	Yes
Documentation PR Link
Any Dependency Changes?
License	MIT

This seems a bit dangerous and I'm not sure if this will cause a regression.

[babel-bot]

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/58578

[liuxingbaoyu]

I didn't use childPath.skip() to make it easier to re-land #16923 in the future.

[nicolo-ribaudo]

This is wrong, what if joint.dia.Graph is a value and not a type?

import * as x from "x";

export import foo = x.foo;

should behave the same as

import { foo } from "x";

export { foo };

[nicolo-ribaudo]

Failure looks relevant :)

[nicolo-ribaudo]

How does this PR interact with the onlyRemoveTypeImports option? Can we have a test verifying that we only remove import type foo = and not import foo = when it's enabled?

[liuxingbaoyu]

TS doesn't seem to support this yet.

[nicolo-ribaudo]

Oh I see. It seems like TypeScript simply does not remove it when the equivalent TS option (verbatimModuleSyntax) is enabled: https://www.typescriptlang.org/play/?verbatimModuleSyntax=true#code/JYWwDg9gTgLgBAbzgIwIZTgXzgMyhEOAIgA8iBuAKFEllwgjgF4V0A6NALyuvGnhgBPMAFNEcVMgDGWXPkKkKvWvAAmInMwnS2JKkNFwAFgHNgWyVN08gA Instead, people should just replace import with type.