Add support to opt-in enable cross-os caching on windows #1056
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lvpx
reviewed
Jan 4, 2023
action.yml
Outdated
| @@ -14,6 +14,10 @@ inputs: | |||
| upload-chunk-size: | |||
| description: 'The chunk size used to split up large files during upload, in bytes' | |||
| required: false | |||
| enableCrossOsArchive: | |||
| description: 'An optional boolean enabled to save and restore cache on windows which could be restored and saved on any platform' | |||
There was a problem hiding this comment.
Suggestion for description: Optional boolean when enabled, allows windows to restore caches created on other platforms.
There was a problem hiding this comment.
Suggested change
| description: 'An optional boolean enabled to save and restore cache on windows which could be restored and saved on any platform' | |
| description: 'An optional boolean when enabled, allows to save and restore caches on windows restored and saved on other platforms' |
This sound better? We need to have save and restore both
There was a problem hiding this comment.
Suggested change
| description: 'An optional boolean enabled to save and restore cache on windows which could be restored and saved on any platform' | |
| description: 'An optional boolean when enabled, allows windows runners to save/restore caches that can be restored/saved respectively on other platforms' |
True, we need save/restore both. How about this?
There was a problem hiding this comment.
@bishal-pdMSFT Does this sound better or this #1056 (comment) ?
There was a problem hiding this comment.
Looks good. The word "respectively" does not seem right fit as we are using /. But I will agree my english is not so good.
There was a problem hiding this comment.
We can remove respectively, I'm also not too sure if this would be grammatically correct.
save/action.yml
Outdated
| @@ -11,6 +11,10 @@ inputs: | |||
| upload-chunk-size: | |||
| description: 'The chunk size used to split up large files during upload, in bytes' | |||
| required: false | |||
| enableCrossOsArchive: | |||
| description: 'An optional boolean enabled to save cache on windows which could be restored on any platform' | |||
There was a problem hiding this comment.
Suggested change
| description: 'An optional boolean enabled to save cache on windows which could be restored on any platform' | |
| description: 'An optional boolean to enable saving a cache on Windows which may be restored later on another platform' |
wolflikeme200
approved these changes
Jan 4, 2023
restore/action.yml
Outdated
| @@ -11,6 +11,10 @@ inputs: | |||
| restore-keys: | |||
| description: 'An ordered list of keys to use for restoring stale cache if no cache hit occurred for key. Note `cache-hit` returns false in this case.' | |||
| required: false | |||
| enableCrossOsArchive: | |||
| description: 'An optional boolean to enable restoring a cache on Windows which was created on another platform' | |||
There was a problem hiding this comment.
This should change according to the one used for top level action
save/action.yml
Outdated
| @@ -11,6 +11,10 @@ inputs: | |||
| upload-chunk-size: | |||
| description: 'The chunk size used to split up large files during upload, in bytes' | |||
| required: false | |||
| enableCrossOsArchive: | |||
| description: 'An optional boolean to enable saving a cache on Windows which may be restored later on another platform' | |||
There was a problem hiding this comment.
This should change according to the one used for top level action
bishal-pdMSFT
approved these changes
Jan 5, 2023
SaschaMann
added a commit
to julia-actions/cache
that referenced
this pull request
Jan 9, 2023
See actions/cache#1056. Fixes #44 --- As pointed out in the upstream actions, symlinks may lead to breakage. I don't think that affects the cached directories, does it? I moved the compiled caching to its own steps, that way we enable people to benefit from cross-OS caching where possible while still caching compiled.
IanButterworth
pushed a commit
to IanButterworth/cache
that referenced
this pull request
Jul 27, 2023
See actions/cache#1056. Fixes julia-actions#44 --- As pointed out in the upstream actions, symlinks may lead to breakage. I don't think that affects the cached directories, does it? I moved the compiled caching to its own steps, that way we enable people to benefit from cross-OS caching where possible while still caching compiled.
1 task
Dakshjain1
pushed a commit
to SvavaCapital/cache
that referenced
this pull request
Apr 19, 2024
* Add support to opt-in enable cross-os caching on windows * Fix tests * Address review comments and update tests * Fix tests * Address review comments * Address review comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Enabling cross os support as an opt-in feature on windows. Previously it was given as default in #1049. And fixing symlink issue pointed out in here: #1010
Motivation and Context
This change is done to allow using saving and restoring cache on Windows which can be restored or is saved on Linux or Mac runners as opt-in feature rather than default. This also bring a fix for symlink issue pointed out by a customer here: #1010.
Types of changes
It would invalidate previous caches present on windows runners due to version mismatch.
Checklist: