Page MenuHomePhabricator
Create Task
Maniphest T356199

Diacritics in talk pages permalinks cause comments to not being found
Closed, ResolvedPublic
Actions

Description

This problem was noticed first at German Wikipedia, with a permalink inbolving a ö. I ran some test at French Wikipedia, as French language has diacritics too.

I took a pair of topics on https://fr.wikipedia.org/wiki/Wikip%C3%A9dia:Le_Bistro/25_janvier_2024. These messages were transcluded to https://fr.wikipedia.org/wiki/Wikip%C3%A9dia:Le_Bistro earlier this week. I emulated the case of a user who accessed and got access to the message when they were on the main page.

According to @matmarex:

ö is double-encoded in the API request. Probably easily fixable

I'm looking for other cases, and I'm sure any language with diacritics will observe this quite serious issue.

Details

SubjectRepoBranchLines +/-
Use decodeURI for comment ID searches as well as heading searchesmediawiki/extensions/DiscussionToolswmf/1.42.0-wmf.16+1 -1
Use decodeURI for comment ID searches as well as heading searchesmediawiki/extensions/DiscussionToolsmaster+1 -1
decodeURI fragments before sending them to discussiontoolsfindcommentmediawiki/extensions/DiscussionToolswmf/1.42.0-wmf.16+1 -1
decodeURI fragments before sending them to discussiontoolsfindcommentmediawiki/extensions/DiscussionToolswmf/1.42.0-wmf.15+1 -1
decodeURI fragments before sending them to discussiontoolsfindcommentmediawiki/extensions/DiscussionToolsmaster+1 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

Trizek-WMF created this task.Jan 30 2024, 5:33 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 30 2024, 5:33 PM
Trizek-WMF added a project: User-notice.Jan 30 2024, 5:35 PM
Trizek-WMF added a parent task: T302011: [Release Ticket] Introduce permalinks on wikitext talk pages.Jan 30 2024, 6:03 PM
Trizek-WMF added a comment.EditedJan 30 2024, 6:21 PM

We have the same problem for Cyrillic language, here for Russian:

gerritbot added a comment.Jan 30 2024, 8:14 PM

Change 994253 had a related patch set uploaded (by DLynch; author: DLynch):

[mediawiki/extensions/DiscussionTools@master] decodeURI fragments before sending them to discussiontoolsfindcomment

https://gerrit.wikimedia.org/r/994253

gerritbot added a project: Patch-For-Review.Jan 30 2024, 8:14 PM
DLynch claimed this task.Jan 30 2024, 8:15 PM
DLynch added a project: Editing-team (Kanban Board).
DLynch moved this task from Incoming to Code Review on the Editing-team (Kanban Board) board.
gerritbot added a comment.Jan 30 2024, 11:54 PM

Change 994253 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] decodeURI fragments before sending them to discussiontoolsfindcomment

https://gerrit.wikimedia.org/r/994253

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.17; 2024-02-06).Jan 31 2024, 1:00 AM
gerritbot added a comment.Jan 31 2024, 5:11 AM

Change 994234 had a related patch set uploaded (by DLynch; author: DLynch):

[mediawiki/extensions/DiscussionTools@wmf/1.42.0-wmf.15] decodeURI fragments before sending them to discussiontoolsfindcomment

https://gerrit.wikimedia.org/r/994234

gerritbot added a comment.Jan 31 2024, 5:12 AM

Change 994235 had a related patch set uploaded (by DLynch; author: DLynch):

[mediawiki/extensions/DiscussionTools@wmf/1.42.0-wmf.16] decodeURI fragments before sending them to discussiontoolsfindcomment

https://gerrit.wikimedia.org/r/994235

gerritbot added a comment.Jan 31 2024, 1:55 PM

Change 994234 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@wmf/1.42.0-wmf.15] decodeURI fragments before sending them to discussiontoolsfindcomment

https://gerrit.wikimedia.org/r/994234

gerritbot added a comment.Jan 31 2024, 1:56 PM

Change 994235 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@wmf/1.42.0-wmf.16] decodeURI fragments before sending them to discussiontoolsfindcomment

https://gerrit.wikimedia.org/r/994235

ReleaseTaggerBot edited projects, added MW-1.42-notes (1.42.0-wmf.15; 2024-01-23); removed MW-1.42-notes (1.42.0-wmf.17; 2024-02-06).Jan 31 2024, 2:00 PM
Stashbot mentioned this in T349653: Permalink redirecting: Support plain section links.Jan 31 2024, 2:08 PM

Mentioned in SAL (#wikimedia-operations) [2024-01-31T14:08:56Z] <urbanecm@deploy2002> Started scap: Backport for [[gerrit:994234|decodeURI fragments before sending them to discussiontoolsfindcomment (T356199)]], [[gerrit:994235|decodeURI fragments before sending them to discussiontoolsfindcomment (T356199)]], [[gerrit:994708|Add an exception for ConvenientDiscussions-style permalinks (T349653)]], [[gerrit:994709|Add an exception for ConvenientDiscussions-style permalinks (T349653)]

Stashbot added a comment.Jan 31 2024, 2:10 PM

Mentioned in SAL (#wikimedia-operations) [2024-01-31T14:10:28Z] <urbanecm@deploy2002> urbanecm and kemayo and matmarex and daimona: Backport for [[gerrit:994234|decodeURI fragments before sending them to discussiontoolsfindcomment (T356199)]], [[gerrit:994235|decodeURI fragments before sending them to discussiontoolsfindcomment (T356199)]], [[gerrit:994708|Add an exception for ConvenientDiscussions-style permalinks (T349653)]], [[gerrit:994709|Add an exception for ConvenientDiscuss

Stashbot added a comment.Jan 31 2024, 2:19 PM

Mentioned in SAL (#wikimedia-operations) [2024-01-31T14:19:27Z] <urbanecm@deploy2002> Finished scap: Backport for [[gerrit:994234|decodeURI fragments before sending them to discussiontoolsfindcomment (T356199)]], [[gerrit:994235|decodeURI fragments before sending them to discussiontoolsfindcomment (T356199)]], [[gerrit:994708|Add an exception for ConvenientDiscussions-style permalinks (T349653)]], [[gerrit:994709|Add an exception for ConvenientDiscussions-style permalinks (T349653)

matmarex moved this task from Code Review to QA on the Editing-team (Kanban Board) board.Jan 31 2024, 2:49 PM
matmarex added a project: Editing QA.
UOzurumba moved this task from To Triage to Not ready to announce on the User-notice board.Feb 1 2024, 6:29 PM
Trizek-WMF moved this task from Not ready to announce to Announce in next Tech/News on the User-notice board.Feb 2 2024, 8:26 AM

For Tech News:

Talk pages permalinks that included diacritics were malfunctioning. This has been fixed.

Tacsipacsi subscribed.Feb 2 2024, 1:48 PM

I think the Tech News entry should mention non-Latin-script languages as well, because they’ve had an even bigger problem: on Latin-script wikis like French or German, more or less of the links were broken, while on non-Latin-script ones like Chinese or Russian, basically all links.

gerritbot added a comment.Feb 2 2024, 5:34 PM

Change 995272 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/extensions/DiscussionTools@master] Use decodeURI for comment ID searches as well as heading searches

https://gerrit.wikimedia.org/r/995272

Esanders subscribed.Feb 2 2024, 5:37 PM

The above patch fixes it for certain comment permalinks too. We will try and deploy it on Monday.

gerritbot added a comment.Feb 2 2024, 5:56 PM

Change 995272 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] Use decodeURI for comment ID searches as well as heading searches

https://gerrit.wikimedia.org/r/995272

ReleaseTaggerBot edited projects, added MW-1.42-notes (1.42.0-wmf.17; 2024-02-06); removed MW-1.42-notes (1.42.0-wmf.15; 2024-01-23).Feb 2 2024, 7:00 PM
UOzurumba moved this task from Announce in next Tech/News to In current Tech/News draft on the User-notice board.Feb 2 2024, 9:25 PM
gerritbot added a comment.Feb 5 2024, 7:47 PM

Change 997279 had a related patch set uploaded (by DLynch; author: Esanders):

[mediawiki/extensions/DiscussionTools@wmf/1.42.0-wmf.16] Use decodeURI for comment ID searches as well as heading searches

https://gerrit.wikimedia.org/r/997279

gerritbot added a comment.Feb 5 2024, 9:09 PM

Change 997279 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@wmf/1.42.0-wmf.16] Use decodeURI for comment ID searches as well as heading searches

https://gerrit.wikimedia.org/r/997279

Stashbot added a comment.Feb 5 2024, 9:42 PM

Mentioned in SAL (#wikimedia-operations) [2024-02-05T21:42:29Z] <cjming@deploy2002> Started scap: Backport for [[gerrit:997279|Use decodeURI for comment ID searches as well as heading searches (T356199)]]

Stashbot added a comment.Feb 5 2024, 9:43 PM

Mentioned in SAL (#wikimedia-operations) [2024-02-05T21:43:49Z] <cjming@deploy2002> cjming and kemayo: Backport for [[gerrit:997279|Use decodeURI for comment ID searches as well as heading searches (T356199)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Stashbot added a comment.Feb 5 2024, 9:55 PM

Mentioned in SAL (#wikimedia-operations) [2024-02-05T21:55:38Z] <cjming@deploy2002> Finished scap: Backport for [[gerrit:997279|Use decodeURI for comment ID searches as well as heading searches (T356199)]] (duration: 13m 08s)

ReleaseTaggerBot edited projects, added MW-1.42-notes (1.42.0-wmf.16; 2024-01-30); removed MW-1.42-notes (1.42.0-wmf.17; 2024-02-06).Feb 5 2024, 10:00 PM
EAkinloose edited projects, added Verified; removed Editing QA.Feb 8 2024, 6:02 AM
EAkinloose moved this task from QA to Ready for Sign Off on the Editing-team (Kanban Board) board.
Maintenance_bot removed a project: Patch-For-Review.Feb 8 2024, 6:30 AM
Esanders closed this task as Resolved.Feb 8 2024, 12:04 PM
UOzurumba moved this task from In current Tech/News draft to Already announced/Archive on the User-notice board.Feb 8 2024, 9:10 PM
matmarex mentioned this in T357601: DiscussionTools heading permalinks don't work on any page that transcludes sections under <h1> headings (e.g. frwiki "Wikipédia:Le Bistro").Feb 15 2024, 2:13 AM
Maintenance_bot edited projects, added User-notice-archive; removed User-notice.Feb 25 2024, 2:30 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits