Uploaded image for project: 'Kafka'
  1. Kafka
  2. KAFKA-18181

Refactor ShareConsumerTest

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • None
    • 4.0.0
    • None
    • None

    Description

      1. `consumeMessages` should return `messagesConsumed` instead of wrapping it in `CompletableFuture`
      2. replace `fail` by `assertDoesNotThrow` or just throw exception
      3. `produceMessages`should return `messagesConsumed` instead of wrapping it in `CompletableFuture`
      4. use `CompletableFuture.runAsync()` instead of ExecutorService. We don't use the interrupt so it is fine to use default executor

      Attachments

        Issue Links

          Activity

            People

              brandboat Kuan Po Tseng
              chia7712 Chia-Ping Tsai
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: