Skip to content

Group webhooks being auto disabled and not re-enabled

Summary

After several failures group webhooks are disabled and not automatically re-enabled.

Steps to reproduce

  1. Setup a group webhook pointing to: https://httpstat.us/500 for comment events
  2. Make 5 comments
  3. Check the hook details
  4. You'll see 4 recent events with 500 responses and no indication that anything is wrong (e.g. no indicator that the hook is disabled temporarily or permanently)
  5. Wait a while
  6. Make another comment
  7. Check the hook details
  8. You won't see any new event :'(

Example Project

https://gitlab.com/tickett/license-test/test/-/issues/1

What is the current bug behavior?

See steps 4 and 8 above

Once 4 failed events have occurred webhook seems to be permanently disable

What is the expected correct behavior?

After 4 failed events, webhook will be temporarily disabled for 1 minute

Relevant logs and/or screenshots

image

image

image

Output of checks

This bug happens on GitLab.com