Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v0.6.2 #451

Merged
merged 5 commits into from
Jun 22, 2019
Merged

v0.6.2 #451

merged 5 commits into from
Jun 22, 2019

Conversation

ericfreese
Copy link
Member

@ericfreese ericfreese commented Jun 22, 2019 •
edited
Loading

  • Review readme
  • Update changelog
  • Bump version
  • Tag version (on master after PR is merged)

@ericfreese
Fix deleting last character in vi mode (#302)
676aebd 
Typing `d` and then `l` runs `vi-delete` and then `vi-forward-char`.  However,
by default, `vi-forward-char` is configured to accept the suggestion. So in
that case, the suggestion was being accepted and the cursor set to the end of
the buffer before the deletion was run.

The reason the user doesn't see the suggestion accepted is that `vi-delete`
doesn't finish until the movement widget is run, so we're already inside of a
`modify` when `accept` is called. `modify` unsets `POSTDISPLAY` before calling
the original widget so when we get to the accept function, `POSTDISPLAY` is
empty and thus accepting the suggestion is a no-op.

The fix is to make sure we reset the cursor to the correct place before running
the original widget.

We skip the test for versions of zsh below 5.0.8 since there was a bug in
earlier versions where deleting the last char did not work.

See http://www.zsh.org/mla/workers/2014/msg01316.html
@ericfreese
Merge pull request #450 from zsh-users/fixes/vi-delete
2498dba 
Fix deleting last character in vi mode (#302)
@ericfreese
Update changelog for v0.6.2 release
66a6de3
@ericfreese
Update readme description to reference new completion strategy
cdf6be4
@ericfreese
v0.6.2
cb52adf
@ericfreese ericfreese merged commit c806055 into master Jun 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ericfreese