This repository was archived by the owner on Oct 25, 2023. It is now read-only.
main menu accessible for screen reader #1877
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would love to see this being merged too! Thanks for the small but helpful fix. |
|
This should be merged. The Main Menu is not accessible for screen readers at the moment. |
|
Thanks for the PR |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The webogram interface has some issues regarding the accessibility for blind users, who use screen reading software. Therefore, the link at the top which is responsible for opening the main menu was not accessible at all.
To solve this, with some help of @dhtstudios, I added the visually-hidden-class and wrote some text into it, in German and English language.