Escape single quote in Julius variable interpolation #221
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
issue ref: yesodweb/yesod#1547 |
|
Code looks good. Can you add a ChangeLog entry and a cabal file version bump? |
|
Is my versioning correct? My commit changed pre-exists function's behavior, so I bumped the second major version number from the left |
|
Even though it changes behavior, it changes behavior in a way that is semantically matching, so I'd make it a minor version bump (third component). |
added 2 commits
August 25, 2018 11:57
4a4eef3 to
f40ee52
Compare
|
@snoyberg Done! Is this okay? |
|
Yay! Thank you too! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.