Parser fails without space between class and ID (Hamlet)

[terickson001]

Having quickly looked through the parser, it seems to intentionally throw an error if there is no space between the end of a class and the beginning of an ID. For example:

• <div .foo#bar>: Fails
• <div #foo.bar>: Succeeds

I would've assumed it was just an oversight in the parser, but it deliberately checks for that exact scenario. Is there a reason a class cannot touch a hash? and why is the opposite
(^ tag 2) valid?

Sorry if i've overlooked some detail explaining this, I just found the inconsistency strange and figured it wasn't intentional.

[snoyberg]

I'm not aware of any reason for this specific quirk, and I'd be open to a PR to fix it, assuming it doesn't introduce regressions.

…

On Wed, Dec 14, 2016, 12:48 AM Tyler Erickson ***@***.***> wrote: Having quickly looked through the parser, it seems to intentionally throw an error if there is no space between the end of a class and the beginning of an ID. For example: - <div .foo#bar>: Fails - <div #foo.bar>: Succeeds I would've assumed it was just an oversight in the parser, but it deliberately checks for that exact scenario. Is there a reason a class cannot touch a hash? and why is the opposite (^ tag 2) valid? Sorry if i've overlooked some detail explaining this, I just found the inconsistency strange and figured it wasn't intentional. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#197>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AADBB07So-XcRiDPvUYimB2gLrvczd7mks5rHyC5gaJpZM4LMUrc> .

[snoyberg]

Fixed by PR #198, thanks!

[ygale]

@snoyberg wrote:

I'd be open to a PR to fix it, assuming it doesn't introduce regressions.

The PR has already been merged. But it does cause a regression, #200.