Distinguish between binary and non-binary strings in MySQL #451
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #448
This PR adds a failing test case demonstrating persistent-mysql writing a
PersistText
but reading aPersistByteString
. The second commit of the PR uses character set information to distinguish betweenTEXT and BLOBbinary and non-binary strings in MySQL, fixing the failing test.This PR could break existing code. If code is relying on reading a
PersistByteString
from a MySQLTEXT
column, that code will break (as it did forgetColumn
).