Skip to content

persistent-qq: Add interpolation support for multirow VALUES syntax #1111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 18, 2020
Merged

persistent-qq: Add interpolation support for multirow VALUES syntax #1111

merged 1 commit into from
Sep 18, 2020

Conversation

sol
Copy link
Contributor

@sol sol commented Aug 18, 2020 •
edited
Loading

Before submitting your PR, check that you've:

After submitting your PR:

  • Update the Changelog.md file with a link to your PR
  • Bumped the version number if there isn't an (unreleased) on the Changelog
  • Check that CI passes (or if it fails, for reasons unrelated to your change, like CI timeouts)

@sol sol force-pushed the persistent-qq-rows branch from d6d8947 to 0b86181 Compare August 18, 2020 04:03
@sol sol mentioned this pull request Aug 18, 2020
Merged
@sol sol force-pushed the persistent-qq-rows branch 2 times, most recently from 8d5453a to 24384db Compare August 22, 2020 05:53
@parsonsmatt
Copy link
Collaborator

It would appear that I have caused a conflict, sorry!

parsonsmatt
parsonsmatt approved these changes Sep 17, 2020
View reviewed changes
persistent-qq/src/Database/Persist/Sql/Raw/QQ.hs
-- UPDATE category SET \@{CategoryRgt} = \@{CategoryRgt} - \#{width} WHERE \@{CategoryRgt} > \#{rgt};
-- UPDATE category SET \@{CategoryLft} = \@{CategoryLft} - \#{width} WHERE \@{CategoryLft} > \#{rgt};
-- SELECT ?? FROM ^{Category} WHERE ^{Category}.\@{CategoryNam} IN %{nams};
-- INSERT INTO ^{Category}(\@{CategoryNam}) VALUES *{`Single` `<$>` nams};
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is awesome 👍

@sol sol force-pushed the persistent-qq-rows branch from 24384db to 3623207 Compare September 17, 2020 20:36
@sol
Copy link
Contributor Author

sol commented Sep 17, 2020

It would appear that I have caused a conflict, sorry!

@parsonsmatt I rebased on master; pending CI, this is good to go.

@parsonsmatt parsonsmatt merged commit edede24 into yesodweb:master Sep 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@parsonsmatt parsonsmatt parsonsmatt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sol @parsonsmatt