Skip to content

Massively simplify apple-universal script #7025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 8, 2023

Conversation

bandi13
Copy link
Contributor

@bandi13 bandi13 commented Dec 1, 2023

No description provided.

@bandi13 bandi13 requested a review from bigbrett December 1, 2023 14:45
@bandi13 bandi13 self-assigned this Dec 1, 2023
Copy link
Contributor

@bigbrett bigbrett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bandi13 Nice simplifications. Can you please update the README documentation detailing the new usage? Also, were these changes tested against the wolfssl-multiplatform example project?

@bandi13
Copy link
Contributor Author

bandi13 commented Dec 1, 2023

retest this please

@bandi13 bandi13 assigned wolfSSL-Bot and unassigned bandi13 Dec 1, 2023
@bandi13
Copy link
Contributor Author

bandi13 commented Dec 1, 2023

No updates to the README necessary. The script performs the same as before just removed the duplicate functions and unified it to a single function.

I don't have the ability to open or edit that project. The only impact might be some paths need modifying.

@bigbrett bigbrett assigned bigbrett and unassigned wolfSSL-Bot Dec 2, 2023
Copy link
Contributor

@bigbrett bigbrett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

built example project against modified script - works as expected.

@bigbrett bigbrett assigned wolfSSL-Bot and unassigned bigbrett Dec 7, 2023
@JacobBarthelmeh JacobBarthelmeh merged commit ae9632b into wolfSSL:master Dec 8, 2023
@bandi13 bandi13 deleted the universalScriptSimplify branch December 11, 2023 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants