Massively simplify apple-universal script #7025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bigbrett
requested changes
Dec 1, 2023
There was a problem hiding this comment.
@bandi13 Nice simplifications. Can you please update the README documentation detailing the new usage? Also, were these changes tested against the wolfssl-multiplatform example project?
|
retest this please |
|
No updates to the README necessary. The script performs the same as before just removed the duplicate functions and unified it to a single function. I don't have the ability to open or edit that project. The only impact might be some paths need modifying. |
bigbrett
approved these changes
Dec 7, 2023
JacobBarthelmeh
approved these changes
Dec 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.