Skip to content

AES GCM ARM64: Replace hardware crypto assembly with generated code #6967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 14, 2023

Conversation

SparkiDev
Copy link
Contributor

@SparkiDev SparkiDev commented Nov 13, 2023

Description

Optimized assembly of AES GCM for ARM64 using hardware crypto instructions.
Code replaced between "START..." and "END...".

Testing

Aarch64 emulator and M1 MacBook Pro

Checklist

  • added tests
  • updated/added doxygen
  • updated appropriate READMEs
  • Updated manual and documentation

@SparkiDev SparkiDev self-assigned this Nov 13, 2023
@SparkiDev SparkiDev force-pushed the aes_gcm_aarch64_hw_crypto branch 3 times, most recently from d132a0d to ab9f666 Compare November 13, 2023 03:18
@SparkiDev SparkiDev assigned wolfSSL-Bot and unassigned SparkiDev Nov 13, 2023
Optimized assembly of AES GCM for ARM64 using hardware crypto
instructions.
Code replaced between "START..." and "END...".
@SparkiDev SparkiDev force-pushed the aes_gcm_aarch64_hw_crypto branch from ab9f666 to c467792 Compare November 13, 2023 23:24
@SparkiDev
Copy link
Contributor Author

retest this please

Copy link
Contributor

@JacobBarthelmeh JacobBarthelmeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huge jump in performance with AES-GCM on ARMv8. Nice!

@JacobBarthelmeh JacobBarthelmeh merged commit 8f7adb2 into wolfSSL:master Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants