Skip to content

Add EXTENDED_KEY_USAGE_free to OpenSSL compat layer. #6916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 9, 2023
Merged

Add EXTENDED_KEY_USAGE_free to OpenSSL compat layer. #6916

merged 1 commit into from
Nov 9, 2023

Conversation

philljj
Copy link
Contributor

@philljj philljj commented Oct 26, 2023 •
edited
Loading

Description

Fixes zd#16804, item 2.

Testing

  • Tested with reproducer in ticket.
  • Updated test_wolfSSL_certs() in tests/api.c to call EXTENDED_KEY_USAGE_free().

@philljj philljj requested a review from anhu October 31, 2023 22:17
@philljj philljj assigned anhu and unassigned philljj Oct 31, 2023
anhu
anhu requested changes Nov 1, 2023
View reviewed changes
Copy link
Member

@anhu anhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Provided comments offline.

@anhu anhu assigned philljj and unassigned anhu and wolfSSL-Bot Nov 1, 2023
@anhu
Copy link
Member

anhu commented Nov 3, 2023

The comments were bad/silly. My mistake.

@anhu anhu self-requested a review November 3, 2023 17:52
anhu
anhu previously approved these changes Nov 3, 2023
View reviewed changes
@philljj philljj assigned wolfSSL-Bot and unassigned philljj Nov 3, 2023
JacobBarthelmeh
JacobBarthelmeh requested changes Nov 3, 2023
View reviewed changes
Copy link
Contributor

@JacobBarthelmeh JacobBarthelmeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a test case added to at least hit the function once with 'make check'

@philljj philljj force-pushed the add_EXTENDED_KEY_USAGE_free branch from 321dd1c to be24d68 Compare November 8, 2023 21:33
@philljj philljj assigned wolfSSL-Bot and unassigned philljj Nov 8, 2023
@JacobBarthelmeh JacobBarthelmeh merged commit 68b6bc8 into wolfSSL:master Nov 9, 2023
@philljj philljj deleted the add_EXTENDED_KEY_USAGE_free branch November 13, 2023 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JacobBarthelmeh JacobBarthelmeh JacobBarthelmeh approved these changes

@anhu anhu anhu left review comments

Assignees

@wolfSSL-Bot wolfSSL-Bot

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@philljj @anhu @JacobBarthelmeh @wolfSSL-Bot