Skip to content

exercise --sys-ca-certs optionin external.test #6910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 1, 2023
Merged

exercise --sys-ca-certs optionin external.test #6910

merged 2 commits into from
Nov 1, 2023

Conversation

bigbrett
Copy link
Contributor

Description

  • Adds --sys-ca-certs to client in external.test, so make check and CI tests can now exercise it (PRB-external-tests now runs on a MacOS node, so the new apple native cert validation can be tested)
  • Simplifies macro inclusion logic in source code so user settings builds only need to define WOLFSSL_APPLE_NATIVE_CERT_VALIDATION instead of defining the HAVE_XXX header detection macros
  • Adds comments in CMake/configure.ac

@bigbrett
Copy link
Contributor Author

Jenkins retest this please

@bigbrett bigbrett assigned bigbrett and wolfSSL-Bot and unassigned bigbrett Oct 25, 2023
@JacobBarthelmeh JacobBarthelmeh merged commit 15fdf6e into wolfSSL:master Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JacobBarthelmeh JacobBarthelmeh JacobBarthelmeh approved these changes

Assignees

@wolfSSL-Bot wolfSSL-Bot

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bigbrett @JacobBarthelmeh @wolfSSL-Bot