refactored button type rules #405
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtrootyy
reviewed
Mar 5, 2022
| <th id="el-input-image" tabindex="-1"> | ||
| <a data-cite="html/input.html#image-button-state-(type=image)">`input type=image`</a> | ||
| <th id="el-button-input-image-reset-submit-form" tabindex="-1"> | ||
| [^button^] with a missing or invalid [^button/type^], <a data-cite="html/input.html#image-button-state-(type=image)">`input type=image`</a>, <a data-cite="html/input.html#submit-button-state-(type=submit)">`input type=submit`</a>, and <a data-cite="html/input.html#reset-button-state-(type=reset)">`input type=reset`</a> , if a descendant of a [^form^] element. |
There was a problem hiding this comment.
Should be fixed as the following:
- Before fixed：[^button^] with a missing or invalid [^button/type^],
- After fixed： `button type=submit`, `button type=reset`, and [^button^] with a missing or invalid [^button/type^],
Because in functionally button type=submit is equal to input type=submit, and button type=reset is equal to input type=reset.
4 tasks
|
closing as incorporating some of these ideas into 446 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #395
divided allowed roles based on whether
inputtype image/submit/reset (and<button>withouttypeor invalidtype)are descendants of aformelementPreview | Diff