-
Notifications
You must be signed in to change notification settings - Fork 48
Addition: adjust allowances for deprecated dpub roles #369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
closes #363 removes allowances for `li` element for dpub roles `doc-biblioentry` and `doc-endnote`. These roles are being deprecated in dpub ARIA 1.1, as authors should use standard list elements, or `role=list` and `role=listitem` elements instead.
scottaohara
added a commit
to scottaohara/validator
that referenced
this pull request
Nov 3, 2021
Related to ARIA in HTML issue w3c/html-aria#369
This was referenced Nov 3, 2021
scottaohara
added a commit
to scottaohara/axe-core
that referenced
this pull request
Nov 3, 2021
[ARIA in HTML](w3c/html-aria#369) is updating the allowances for the `<li>` element to remove the dpub roles [`doc-biblioentry`](https://w3c.github.io/dpub-aria/#doc-biblioentry) and [`doc-endnote`](https://w3c.github.io/dpub-aria/#doc-endnote). These roles are being deprecated in dpub ARIA 1.1, as authors should use standard list elements, or `role=list` and `role=listitem` elements instead.
- add authors SHOULD NOT - add note to explain
patrickhlauke
approved these changes
Jan 7, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
sideshowbarker
pushed a commit
to validator/validator
that referenced
this pull request
Jan 21, 2022
Related to ARIA in HTML issue w3c/html-aria#369
scottaohara
added a commit
that referenced
this pull request
May 19, 2022
pkra
pushed a commit
to w3c/aria
that referenced
this pull request
May 20, 2024
directly reference the following PRs in the changelog, and prepend each entry with the appropriate 'label' related to w3c/html-aria#419 - w3c/html-aria#352 - w3c/html-aria#367 (and follow on [commit](w3c/html-aria@9cc2c0a)) - w3c/html-aria#360 - w3c/html-aria#353 - w3c/html-aria#372 - w3c/html-aria#402 - w3c/html-aria#404 - w3c/html-aria#403 - w3c/html-aria#396 - w3c/html-aria#391 - w3c/html-aria#369 - w3c/html-aria#381
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Meets 2 implementations req
Indicates that a spec change has met the necessary 2 implementations needed to merge.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #363
revises allowances for
li
element to specify dpub rolesdoc-biblioentry
anddoc-endnote
to authors SHOULD NOT. These roles are being deprecated in dpub ARIA 1.1. Authors should use standard list elements instead.As there is a clear preference to use list/listitem elements, if possible conformance checkers should indicate to use such elements and flag errors, rather than warnings.
Need at least two checkers to accept this change before we can merge.
Preview | Diff
Preview | Diff