Skip to content

Update mappings for sub and sup for IA2 #174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
joanmarie opened this issue Mar 19, 2019 · 4 comments
Closed

Update mappings for sub and sup for IA2 #174

joanmarie opened this issue Mar 19, 2019 · 4 comments
Assignees
@joanmarie

Comments

@joanmarie
Copy link
Contributor

After some discussion in a Mozilla issue, the conclusion is that sub and sup should have accessible objects in addition to exposing the properties via text attribute. The mapping should be to IA2_ROLE_TEXT_FRAME.

Will do a pull request shortly.
@joanmarie joanmarie self-assigned this Mar 19, 2019
@joanmarie
Copy link
Contributor Author

So I have a "draft" pull request (#175). It's a draft because, as I've since commented on the Mozilla issue, it's not clear to me if "keep(ing) the text attributes as they are" means on the parent container or the text frame which is now being exposed (or both). Once Jamie chimes in, I'll finalize my PR.

@scottaohara
Copy link
Member

Thank you

@joanmarie
Copy link
Contributor Author

My pleasure. Jamie has answered on the bug and I've updated my pull request accordingly. Please review. Thanks!

@scottaohara
Copy link
Member

closed by #175

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joanmarie joanmarie

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@joanmarie @scottaohara