Skip to content

Add mappings for ins and del #141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
joanmarie opened this issue Aug 13, 2018 · 2 comments · Fixed by #213
Closed

Add mappings for ins and del #141

joanmarie opened this issue Aug 13, 2018 · 2 comments · Fixed by #213

Comments

@joanmarie
Copy link
Contributor

The ins and del elements currently are shown as having no accessible object for three of the four platforms. In addition, for ATK it states that exposure should be done via text attribute.

In order to easily support presentation (or exclusion, should the user prefer) of edits marked up via ins and del, I think there should be an accessible object. IAccessible2 has just added roles for each of these: https://github.com/LinuxA11y/IAccessible2/blob/master/api/AccessibleRole.idl#L307. ATK and AT-SPI2 will soon, hopefully: https://gitlab.gnome.org/GNOME/atk/issues/2.

In terms of the mappings for ATK, until the new roles have been created, I think using ROLE_SECTION makes sense (i.e. the same mapping as div because ins and del can have child elements.)

We still need a way to make it easy for ATs in Linux to find these elements. A text attribute (be it formatting or something like diff:del/diff:ins) doesn't make sense to me as Orca doesn't bother getting text attributes unless a user explicitly asks for them via command. Checking all text attributes on the slim chance there's an ins or del will not be performant. Orca does, for a variety of reasons, check object attributes. Thus I think exposure via object attribute is the way to go. Could we use xml-roles for that? If not, an object attribute like diff:del and diff:ins should work.

@joanmarie
Copy link
Contributor Author

@melanierichards: This IA2 now exposes these via IA2_ROLE_CONTENT_INSERTION and IA2_ROLE_CONTENT_DELETION. And we'll be exposing them for ATK as well. What about for UIA?

@scottaohara
Copy link
Member

scottaohara commented Apr 26, 2019

@melanierichards @stevefaulkner I've started a branch for updating del and ins, please feel free to update if you have time.

Thoughts I was having: do we want to add a comment to each referencing that role=insertion and role=deletion are in draft?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants