Skip to content

[scroll-animations-1] Define view-timeline and animation-range-* as not animatable #8436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

cdoublev
Copy link
Collaborator

@cdoublev cdoublev commented Feb 9, 2023

This PR replaces the default Animation Type: see individual properties by an explicit Animation Type: not animatable for the view-timeline and animation-range shorthands.

The Animation type of animation, transition, scroll-timeline, which are shorthands whose sub-properties are all not animatable, is explicitly defined as not animatable instead of see individual properties, like view-timeline and animation-range.

In my opinion, see individual properties should be used only when some/all sub-properties are animatable.

This PR also replaces Animatable with Animation type for animation-range-*, as required by Web Animations:

How property values combine is defined by the Animation type line in each property’s property definition table

@cdoublev cdoublev changed the title [scroll-animations-1] Explicitly define view-timeline as not animatable [scroll-animations-1] Define view-timeline and animation-range-* as not animatable Feb 9, 2023
@tabatkins
Copy link
Member

Closing for the same reason as #8435 (comment)

@tabatkins tabatkins closed this Feb 10, 2023
@cdoublev cdoublev deleted the animation-type-issue-14 branch February 12, 2023 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants