[css-text-4] 'white-space' and longhand integration #8274
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6dcd4be to
4905670
Compare
…te space processing rules.
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Mar 28, 2023
This patch turns the `white-space` property to a shorthand under a runtime switch `CSSWhiteSpaceShorthand`. The parser and serializer in this CL supports the spec change committed on 1st March, 2023[1], which addressed the multi-value syntax request[2]. This patch also adds: * The `white-space-collapse` property. * The `nowrap` value to the `text-wrap` property. to map all the existing `white-space` values. The switch is currently off, because enabling it causes several test failures in DOM, editing, copy/paste, accessibility, and more, but when it's turned on, CSS parsing tests added in this CL should pass. The plan is to fix these failures in following CLs. When all tests and additional tests for editing/etc. are all fixed, we can turn the switch on. The `EWhiteSpace` enum is changed to bit-flags of the longhands (`white-space-collapse` and `text-wrap`.) See `white_spae.h`. Regarding the storage in the `ComputedStyleBase`, having both storage (for when the flag is on and off) is a waste, both from memory and from read/write code performance point of view, so the longhands storage is used even when the flag is off by customized `ComputedStyle` functions; i.e., the storage for the longhand version of the `white-space` is no longer used. But this CL still preserves 1 bit for the `white-space` to avoid changing the generator only for this transition period. [1] w3c/csswg-drafts#8274 [2] w3c/csswg-drafts#5382 Bug: 1417543 Change-Id: I47080d0f10a4a5f366e3d855acfa5e584c029595
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Mar 28, 2023
This patch turns the `white-space` property to a shorthand under a runtime switch `CSSWhiteSpaceShorthand`. The parser and serializer in this CL supports the spec change committed on 1st March, 2023[1], which addressed the multi-value syntax request[2]. This patch also adds: * The `white-space-collapse` property. * The `nowrap` value to the `text-wrap` property. to map all the existing `white-space` values. The switch is currently off, because enabling it causes several test failures in DOM, editing, copy/paste, accessibility, and more, but when it's turned on, CSS parsing tests added in this CL should pass. The plan is to fix these failures in following CLs. When all tests and additional tests for editing/etc. are all fixed, we can turn the switch on. The `EWhiteSpace` enum is changed to bit-flags of the longhands (`white-space-collapse` and `text-wrap`.) See `white_spae.h`. Regarding the storage in the `ComputedStyleBase`, having both storage (for when the flag is on and off) is a waste, both from memory and from read/write code performance point of view, so the longhands storage is used even when the flag is off by customized `ComputedStyle` functions; i.e., the storage for the longhand version of the `white-space` is no longer used. But this CL still preserves 1 bit for the `white-space` to avoid changing the generator only for this transition period. [1] w3c/csswg-drafts#8274 [2] w3c/csswg-drafts#5382 Bug: 1417543 Change-Id: I47080d0f10a4a5f366e3d855acfa5e584c029595
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Mar 28, 2023
This patch turns the `white-space` property to a shorthand under a runtime switch `CSSWhiteSpaceShorthand`. The parser and serializer in this CL supports the spec change committed on 1st March, 2023[1], which addressed the multi-value syntax request[2]. This patch also adds: * The `white-space-collapse` property. * The `nowrap` value to the `text-wrap` property. to map all the existing `white-space` values. The switch is currently off, because enabling it causes several test failures in DOM, editing, copy/paste, accessibility, and more, but when it's turned on, CSS parsing tests added in this CL should pass. The plan is to fix these failures in following CLs. When all tests and additional tests for editing/etc. are all fixed, we can turn the switch on. The `EWhiteSpace` enum is changed to bit-flags of the longhands (`white-space-collapse` and `text-wrap`.) See `white_spae.h`. Regarding the storage in the `ComputedStyleBase`, having both storage (for when the flag is on and off) is a waste, both from memory and from read/write code performance point of view, so the longhands storage is used even when the flag is off by customized `ComputedStyle` functions; i.e., the storage for the longhand version of the `white-space` is no longer used. But this CL still preserves 1 bit for the `white-space` to avoid changing the generator only for this transition period. [1] w3c/csswg-drafts#8274 [2] w3c/csswg-drafts#5382 Bug: 1417543 Change-Id: I47080d0f10a4a5f366e3d855acfa5e584c029595
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Mar 28, 2023
This patch turns the `white-space` property to a shorthand under a runtime switch `CSSWhiteSpaceShorthand`. The parser and serializer in this CL supports the spec change committed on 1st March, 2023[1], which addressed the multi-value syntax request[2]. This patch also adds: * The `white-space-collapse` property. * The `nowrap` value to the `text-wrap` property. to map all the existing `white-space` values. The switch is currently off, because enabling it causes several test failures in DOM, editing, copy/paste, accessibility, and more, but when it's turned on, CSS parsing tests added in this CL should pass. The plan is to fix these failures in following CLs. When all tests and additional tests for editing/etc. are all fixed, we can turn the switch on. The `EWhiteSpace` enum is changed to bit-flags of the longhands (`white-space-collapse` and `text-wrap`.) See `white_spae.h`. Regarding the storage in the `ComputedStyleBase`, having both storage (for when the flag is on and off) is a waste, both from memory and from read/write code performance point of view, so the longhands storage is used even when the flag is off by customized `ComputedStyle` functions; i.e., the storage for the longhand version of the `white-space` is no longer used. But this CL still preserves 1 bit for the `white-space` to avoid changing the generator only for this transition period. [1] w3c/csswg-drafts#8274 [2] w3c/csswg-drafts#5382 Bug: 1417543 Change-Id: I47080d0f10a4a5f366e3d855acfa5e584c029595 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4232738 Reviewed-by: Anders Hartvoll Ruud <[email protected]> Commit-Queue: Koji Ishii <[email protected]> Cr-Commit-Position: refs/heads/main@{#1123192}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Mar 28, 2023
This patch turns the `white-space` property to a shorthand under a runtime switch `CSSWhiteSpaceShorthand`. The parser and serializer in this CL supports the spec change committed on 1st March, 2023[1], which addressed the multi-value syntax request[2]. This patch also adds: * The `white-space-collapse` property. * The `nowrap` value to the `text-wrap` property. to map all the existing `white-space` values. The switch is currently off, because enabling it causes several test failures in DOM, editing, copy/paste, accessibility, and more, but when it's turned on, CSS parsing tests added in this CL should pass. The plan is to fix these failures in following CLs. When all tests and additional tests for editing/etc. are all fixed, we can turn the switch on. The `EWhiteSpace` enum is changed to bit-flags of the longhands (`white-space-collapse` and `text-wrap`.) See `white_spae.h`. Regarding the storage in the `ComputedStyleBase`, having both storage (for when the flag is on and off) is a waste, both from memory and from read/write code performance point of view, so the longhands storage is used even when the flag is off by customized `ComputedStyle` functions; i.e., the storage for the longhand version of the `white-space` is no longer used. But this CL still preserves 1 bit for the `white-space` to avoid changing the generator only for this transition period. [1] w3c/csswg-drafts#8274 [2] w3c/csswg-drafts#5382 Bug: 1417543 Change-Id: I47080d0f10a4a5f366e3d855acfa5e584c029595 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4232738 Reviewed-by: Anders Hartvoll Ruud <[email protected]> Commit-Queue: Koji Ishii <[email protected]> Cr-Commit-Position: refs/heads/main@{#1123192}
cookiecrook
pushed a commit
to cookiecrook/wpt
that referenced
this pull request
Mar 29, 2023
This patch turns the `white-space` property to a shorthand under a runtime switch `CSSWhiteSpaceShorthand`. The parser and serializer in this CL supports the spec change committed on 1st March, 2023[1], which addressed the multi-value syntax request[2]. This patch also adds: * The `white-space-collapse` property. * The `nowrap` value to the `text-wrap` property. to map all the existing `white-space` values. The switch is currently off, because enabling it causes several test failures in DOM, editing, copy/paste, accessibility, and more, but when it's turned on, CSS parsing tests added in this CL should pass. The plan is to fix these failures in following CLs. When all tests and additional tests for editing/etc. are all fixed, we can turn the switch on. The `EWhiteSpace` enum is changed to bit-flags of the longhands (`white-space-collapse` and `text-wrap`.) See `white_spae.h`. Regarding the storage in the `ComputedStyleBase`, having both storage (for when the flag is on and off) is a waste, both from memory and from read/write code performance point of view, so the longhands storage is used even when the flag is off by customized `ComputedStyle` functions; i.e., the storage for the longhand version of the `white-space` is no longer used. But this CL still preserves 1 bit for the `white-space` to avoid changing the generator only for this transition period. [1] w3c/csswg-drafts#8274 [2] w3c/csswg-drafts#5382 Bug: 1417543 Change-Id: I47080d0f10a4a5f366e3d855acfa5e584c029595 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4232738 Reviewed-by: Anders Hartvoll Ruud <[email protected]> Commit-Queue: Koji Ishii <[email protected]> Cr-Commit-Position: refs/heads/main@{#1123192}
cookiecrook
pushed a commit
to cookiecrook/wpt
that referenced
this pull request
Apr 8, 2023
This patch turns the `white-space` property to a shorthand under a runtime switch `CSSWhiteSpaceShorthand`. The parser and serializer in this CL supports the spec change committed on 1st March, 2023[1], which addressed the multi-value syntax request[2]. This patch also adds: * The `white-space-collapse` property. * The `nowrap` value to the `text-wrap` property. to map all the existing `white-space` values. The switch is currently off, because enabling it causes several test failures in DOM, editing, copy/paste, accessibility, and more, but when it's turned on, CSS parsing tests added in this CL should pass. The plan is to fix these failures in following CLs. When all tests and additional tests for editing/etc. are all fixed, we can turn the switch on. The `EWhiteSpace` enum is changed to bit-flags of the longhands (`white-space-collapse` and `text-wrap`.) See `white_spae.h`. Regarding the storage in the `ComputedStyleBase`, having both storage (for when the flag is on and off) is a waste, both from memory and from read/write code performance point of view, so the longhands storage is used even when the flag is off by customized `ComputedStyle` functions; i.e., the storage for the longhand version of the `white-space` is no longer used. But this CL still preserves 1 bit for the `white-space` to avoid changing the generator only for this transition period. [1] w3c/csswg-drafts#8274 [2] w3c/csswg-drafts#5382 Bug: 1417543 Change-Id: I47080d0f10a4a5f366e3d855acfa5e584c029595 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4232738 Reviewed-by: Anders Hartvoll Ruud <[email protected]> Commit-Queue: Koji Ishii <[email protected]> Cr-Commit-Position: refs/heads/main@{#1123192}
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Apr 13, 2023
…orthand, a=testonly Automatic update from web-platform-tests [white-space] Turn `white-space` to a shorthand This patch turns the `white-space` property to a shorthand under a runtime switch `CSSWhiteSpaceShorthand`. The parser and serializer in this CL supports the spec change committed on 1st March, 2023[1], which addressed the multi-value syntax request[2]. This patch also adds: * The `white-space-collapse` property. * The `nowrap` value to the `text-wrap` property. to map all the existing `white-space` values. The switch is currently off, because enabling it causes several test failures in DOM, editing, copy/paste, accessibility, and more, but when it's turned on, CSS parsing tests added in this CL should pass. The plan is to fix these failures in following CLs. When all tests and additional tests for editing/etc. are all fixed, we can turn the switch on. The `EWhiteSpace` enum is changed to bit-flags of the longhands (`white-space-collapse` and `text-wrap`.) See `white_spae.h`. Regarding the storage in the `ComputedStyleBase`, having both storage (for when the flag is on and off) is a waste, both from memory and from read/write code performance point of view, so the longhands storage is used even when the flag is off by customized `ComputedStyle` functions; i.e., the storage for the longhand version of the `white-space` is no longer used. But this CL still preserves 1 bit for the `white-space` to avoid changing the generator only for this transition period. [1] w3c/csswg-drafts#8274 [2] w3c/csswg-drafts#5382 Bug: 1417543 Change-Id: I47080d0f10a4a5f366e3d855acfa5e584c029595 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4232738 Reviewed-by: Anders Hartvoll Ruud <[email protected]> Commit-Queue: Koji Ishii <[email protected]> Cr-Commit-Position: refs/heads/main@{#1123192} -- wpt-commits: c5dc05f232b36134c54031244de60d7bd5c32721 wpt-pr: 39244
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Series of commits for properly integrating the L3 'white-space' shorthand and L4 longhand definitions in CSS Text Level 4.