[cssom] Have property setters append new declaration rather than set in place #2516
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in place. This resolves #1898.
|
I'll have a look at the wpt and see if there's any existing to update. |
|
Test is in web-platform-tests/wpt#10354. |
bors-servo
pushed a commit
to servo/servo
that referenced
this pull request
Apr 7, 2018
Have CSSOM append rather than replace slot in declaration block The early return for identical setting in importance matching as well as the comment before `index_to_remove` are removed because the order is web-exposing regardless of whether it's from CSSOM or parsing. e.g. `top: 1px; left: 2px; top: 1px;` is effectively `left: 2px; top: 1px;`, not `top: 1px; left: 2px;`. This is patch for [bug 1415330](https://bugzilla.mozilla.org/show_bug.cgi?id=1415330), for spec change in w3c/csswg-drafts#2516. And corresponding test will be added in web-platform-tests/wpt#10354. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20582) <!-- Reviewable:end -->
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Apr 7, 2018
…eclaration block (from upsuper:cssom-append); r=emilio The early return for identical setting in importance matching as well as the comment before `index_to_remove` are removed because the order is web-exposing regardless of whether it's from CSSOM or parsing. e.g. `top: 1px; left: 2px; top: 1px;` is effectively `left: 2px; top: 1px;`, not `top: 1px; left: 2px;`. This is patch for [bug 1415330](https://bugzilla.mozilla.org/show_bug.cgi?id=1415330), for spec change in w3c/csswg-drafts#2516. And corresponding test will be added in web-platform-tests/wpt#10354. Source-Repo: https://github.com/servo/servo Source-Revision: ccc9d1c4c2877ebc82158b91dc27e1be74fae237 --HG-- extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear extra : subtree_revision : 9c326db0bca76383e0c47c53baa0fd7f20481130
emilio
approved these changes
Apr 11, 2018
|
@emilio Well, I don't think you should merge it without approval from the current editor really... |
|
@upsuper we added Emilio as editor today |
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Oct 2, 2019
…eclaration block (from upsuper:cssom-append); r=emilio The early return for identical setting in importance matching as well as the comment before `index_to_remove` are removed because the order is web-exposing regardless of whether it's from CSSOM or parsing. e.g. `top: 1px; left: 2px; top: 1px;` is effectively `left: 2px; top: 1px;`, not `top: 1px; left: 2px;`. This is patch for [bug 1415330](https://bugzilla.mozilla.org/show_bug.cgi?id=1415330), for spec change in w3c/csswg-drafts#2516. And corresponding test will be added in web-platform-tests/wpt#10354. Source-Repo: https://github.com/servo/servo Source-Revision: ccc9d1c4c2877ebc82158b91dc27e1be74fae237 UltraBlame original commit: 62908a56c59f34e4dd5175717228cd514ac65c60
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Oct 2, 2019
…eclaration block (from upsuper:cssom-append); r=emilio The early return for identical setting in importance matching as well as the comment before `index_to_remove` are removed because the order is web-exposing regardless of whether it's from CSSOM or parsing. e.g. `top: 1px; left: 2px; top: 1px;` is effectively `left: 2px; top: 1px;`, not `top: 1px; left: 2px;`. This is patch for [bug 1415330](https://bugzilla.mozilla.org/show_bug.cgi?id=1415330), for spec change in w3c/csswg-drafts#2516. And corresponding test will be added in web-platform-tests/wpt#10354. Source-Repo: https://github.com/servo/servo Source-Revision: ccc9d1c4c2877ebc82158b91dc27e1be74fae237 UltraBlame original commit: 62908a56c59f34e4dd5175717228cd514ac65c60
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Oct 2, 2019
…eclaration block (from upsuper:cssom-append); r=emilio The early return for identical setting in importance matching as well as the comment before `index_to_remove` are removed because the order is web-exposing regardless of whether it's from CSSOM or parsing. e.g. `top: 1px; left: 2px; top: 1px;` is effectively `left: 2px; top: 1px;`, not `top: 1px; left: 2px;`. This is patch for [bug 1415330](https://bugzilla.mozilla.org/show_bug.cgi?id=1415330), for spec change in w3c/csswg-drafts#2516. And corresponding test will be added in web-platform-tests/wpt#10354. Source-Repo: https://github.com/servo/servo Source-Revision: ccc9d1c4c2877ebc82158b91dc27e1be74fae237 UltraBlame original commit: 62908a56c59f34e4dd5175717228cd514ac65c60
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves #1898.