[css-values] Total attr()-tainting for substitution values #11218
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This may have been the intended meaning of the spec text already, but I think we should clearly state the outcome of w3c#5092: partial tainting of custom properties was proposed in that issue, discussed, objected to, and therefore *not* accepted. This PR hopefully makes it clear that attr()-tainting applies to whole substitution values, for now.
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Nov 22, 2024
Clean up wpt tests for attr() security violations, add tests for url() function and tests reflecting the following spec changes [0]. [0] w3c/csswg-drafts#11218 Bug: 40320391 Change-Id: I05d73f4ee78aff1ccd0ae7f90584f5f5a9353b09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6020647 Reviewed-by: Anders Hartvoll Ruud <[email protected]> Commit-Queue: Munira Tursunova <[email protected]> Cr-Commit-Position: refs/heads/main@{#1386745}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Nov 22, 2024
Clean up wpt tests for attr() security violations, add tests for url() function and tests reflecting the following spec changes [0]. [0] w3c/csswg-drafts#11218 Bug: 40320391 Change-Id: I05d73f4ee78aff1ccd0ae7f90584f5f5a9353b09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6020647 Reviewed-by: Anders Hartvoll Ruud <[email protected]> Commit-Queue: Munira Tursunova <[email protected]> Cr-Commit-Position: refs/heads/main@{#1386745}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Nov 22, 2024
Clean up wpt tests for attr() security violations, add tests for url() function and tests reflecting the following spec changes [0]. [0] w3c/csswg-drafts#11218 Bug: 40320391 Change-Id: I05d73f4ee78aff1ccd0ae7f90584f5f5a9353b09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6020647 Reviewed-by: Anders Hartvoll Ruud <[email protected]> Commit-Queue: Munira Tursunova <[email protected]> Cr-Commit-Position: refs/heads/main@{#1386745}
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Nov 28, 2024
…a=testonly Automatic update from web-platform-tests Clean up wpt tests for attr() security Clean up wpt tests for attr() security violations, add tests for url() function and tests reflecting the following spec changes [0]. [0] w3c/csswg-drafts#11218 Bug: 40320391 Change-Id: I05d73f4ee78aff1ccd0ae7f90584f5f5a9353b09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6020647 Reviewed-by: Anders Hartvoll Ruud <[email protected]> Commit-Queue: Munira Tursunova <[email protected]> Cr-Commit-Position: refs/heads/main@{#1386745} -- wpt-commits: 5f258ba9dcd1e9c6fad46cac100a6036a9ec11bb wpt-pr: 49330
i3roly
pushed a commit
to i3roly/firefox-dynasty
that referenced
this pull request
Nov 30, 2024
…a=testonly Automatic update from web-platform-tests Clean up wpt tests for attr() security Clean up wpt tests for attr() security violations, add tests for url() function and tests reflecting the following spec changes [0]. [0] w3c/csswg-drafts#11218 Bug: 40320391 Change-Id: I05d73f4ee78aff1ccd0ae7f90584f5f5a9353b09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6020647 Reviewed-by: Anders Hartvoll Ruud <[email protected]> Commit-Queue: Munira Tursunova <[email protected]> Cr-Commit-Position: refs/heads/main@{#1386745} -- wpt-commits: 5f258ba9dcd1e9c6fad46cac100a6036a9ec11bb wpt-pr: 49330
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Dec 1, 2024
…a=testonly Automatic update from web-platform-tests Clean up wpt tests for attr() security Clean up wpt tests for attr() security violations, add tests for url() function and tests reflecting the following spec changes [0]. [0] w3c/csswg-drafts#11218 Bug: 40320391 Change-Id: I05d73f4ee78aff1ccd0ae7f90584f5f5a9353b09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6020647 Reviewed-by: Anders Hartvoll Ruud <andruudchromium.org> Commit-Queue: Munira Tursunova <mooniragoogle.com> Cr-Commit-Position: refs/heads/main{#1386745} -- wpt-commits: 5f258ba9dcd1e9c6fad46cac100a6036a9ec11bb wpt-pr: 49330 UltraBlame original commit: 5c0f7fe9c0c6d184d5648d9e1b137c70e334e7d5
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Dec 1, 2024
…a=testonly Automatic update from web-platform-tests Clean up wpt tests for attr() security Clean up wpt tests for attr() security violations, add tests for url() function and tests reflecting the following spec changes [0]. [0] w3c/csswg-drafts#11218 Bug: 40320391 Change-Id: I05d73f4ee78aff1ccd0ae7f90584f5f5a9353b09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6020647 Reviewed-by: Anders Hartvoll Ruud <andruudchromium.org> Commit-Queue: Munira Tursunova <mooniragoogle.com> Cr-Commit-Position: refs/heads/main{#1386745} -- wpt-commits: 5f258ba9dcd1e9c6fad46cac100a6036a9ec11bb wpt-pr: 49330 UltraBlame original commit: 5c0f7fe9c0c6d184d5648d9e1b137c70e334e7d5
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Dec 1, 2024
…a=testonly Automatic update from web-platform-tests Clean up wpt tests for attr() security Clean up wpt tests for attr() security violations, add tests for url() function and tests reflecting the following spec changes [0]. [0] w3c/csswg-drafts#11218 Bug: 40320391 Change-Id: I05d73f4ee78aff1ccd0ae7f90584f5f5a9353b09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6020647 Reviewed-by: Anders Hartvoll Ruud <andruudchromium.org> Commit-Queue: Munira Tursunova <mooniragoogle.com> Cr-Commit-Position: refs/heads/main{#1386745} -- wpt-commits: 5f258ba9dcd1e9c6fad46cac100a6036a9ec11bb wpt-pr: 49330 UltraBlame original commit: 5c0f7fe9c0c6d184d5648d9e1b137c70e334e7d5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This may have been the intended meaning of the spec text already, but I think we should clearly state the outcome of #5092: partial tainting of custom properties was proposed in that issue, discussed, objected to, and therefore not accepted.
This PR hopefully makes it clear that attr()-tainting applies to whole substitution values, for now.