-
Notifications
You must be signed in to change notification settings - Fork 715
[css-scroll-snap-2] Drop scroll-start and add issue to :snapped #10505
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Towards resolving [6985](w3c#6985 (comment)) this patch removes scroll-start from the spec and notes that :snapped is being replaced.
Interaction with RTL and LTR</h4> | ||
|
||
Logical properties are offered for length offsets that should be flow relative. Furthermore, the ''end'' and ''start'' keywords are always logical. | ||
|
||
The 'scroll-start-target' property {#scroll-start-target} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
scroll-start-target says it is a shorthand but I think that's no longer true since becoming a single property, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes that's correct. Good catch. I've removed the "shorthand" references.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remnants of scroll-start-target-*
longhands are still there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for pointing this out. Created #10554 to remove them.
@@ -70,36 +71,6 @@ First Layout {#first-layout} | |||
Motivating Examples {#examples} | |||
=============================== | |||
|
|||
<div class="example"> | |||
A carousel that starts in the middle: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is still a good example, it just requires that we add a class to the middle item in the carousel which sets scroll-start-target. This at least works for the case where the carousel shows one item at a time or when the items are snap center aligned. Can you update the example instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good, done.
Towards resolving 6985 this patch removes scroll-start from the spec and notes that :snapped is being replaced.